Merge pull request binary-com#37 from akmal-binary/payment-methods

Fix: empty spacing in advertisement and buy-sell page
khalid-deriv · Feb 25, 2022 · acaf1ec · acaf1ec
2 parents 216db99 + b829e49
commit acaf1ec
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/p2p/src/components/advertiser-page/advertiser-page.scss b/packages/p2p/src/components/advertiser-page/advertiser-page.scss
@@ -225,7 +225,7 @@
 
             @include mobile {
                 grid-template-columns: 2fr 1fr;
-                height: 180px;
+                min-height: 105px;
                 padding: 1.6rem;
                 width: 100vw;
             }

diff --git a/packages/p2p/src/components/buy-sell/buy-sell-modal.jsx b/packages/p2p/src/components/buy-sell/buy-sell-modal.jsx
@@ -76,7 +76,7 @@ const BuySellModal = ({ table_type, selected_ad, should_show_popup, setShouldSho
 
     const Form = general_store.nickname ? BuySellForm : NicknameForm;
     const modal_title = my_profile_store.should_show_add_payment_method_form
-        ? localize('Add a payment method')
+        ? localize('Add payment method')
         : table_type === buy_sell.BUY
         ? localize('Buy {{ currency }}', { currency: selected_ad.account_currency })
         : localize('Sell {{ currency }}', { currency: selected_ad.account_currency });

diff --git a/packages/p2p/src/components/buy-sell/buy-sell-row.jsx b/packages/p2p/src/components/buy-sell/buy-sell-row.jsx
@@ -17,7 +17,7 @@ const BuySellRow = ({ row: advert }) => {
         // This allows for the sliding animation on the Buy/Sell toggle as it pushes
         // an empty item with an item that holds the same height of the toggle container.
         // Also see: buy-sell-table.jsx
-        return <div style={{ height: '177px' }} />;
+        return <div style={{ height: '140px' }} />;
     }
 
     if (advert.id === 'NO_MATCH_ROW') {

diff --git a/packages/p2p/src/components/buy-sell/buy-sell-row.scss b/packages/p2p/src/components/buy-sell/buy-sell-row.scss
@@ -2,7 +2,7 @@
     @include mobile {
         border-bottom: 1px solid var(--general-section-1);
         padding: 1.6rem;
-        height: 18.6rem;
+        min-height: 18.6rem;
         display: flex;
         flex-direction: column;
     }