Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added interface matcher #6

Merged
merged 2 commits into from
Jul 25, 2017
Merged

added interface matcher #6

merged 2 commits into from
Jul 25, 2017

Conversation

marcgreenstock
Copy link
Contributor

Thanks for making this, I was just about to start my own until I discovered you have already done so.

This PR adds an interface matcher. Hope you like it :)

@khamusa
Copy link
Owner

khamusa commented Jul 25, 2017

Thank you @marcgreenstock! This is definetely missing!

I'm not sure about the naming. I feel it doesn't read very well expect(...).to interface. I'd rather use implement which is the term used on the overall graphql docs. What do you think of expect(...).to implement(interface1, interface 2...) ?

@marcgreenstock
Copy link
Contributor Author

hey @khamusa you're absolutely right. interfaces is deprecated anyway. I will change it now, just a sec.

@khamusa khamusa merged commit 9aab8b8 into khamusa:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants