-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements #64
Conversation
Add rules to highlight scrollbar thumb and buttons when hovering over it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work, thanks a bunch mate. 2 points to address though.
Reg. the scrollbar, it might not be possible since there has never been a consolidated approach to style it properly across the browsers, it always feels hacky to do it, so feel free to play around with it as you see fit.
gui/_global.scss
Outdated
a { | ||
text-decoration: none; | ||
} | ||
|
||
a:hover { | ||
text-decoration: underline; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a hyperlink rule available with _typography.scss
. Could you please help move this over there? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'm on it.
gui/_global.scss
Outdated
var(--button-shade-light-default) 45%, | ||
var(--button-shade-light-active) 45% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color tone is too strong in comparison with the video. Feel free to declare a new variable and use a different color to apply here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
gui/_global.scss
Outdated
var(--button-shade-light-default) 45%, | ||
var(--button-shade-light-active) 45% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
- Fixed scrollbar colours. - Added rules to style active scrollbar.
Turns out I used the wrong variables. It's all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks mate.
What's changed:
About the scrollbar buttons
The scrollbar buttons in Windows 7 behave like this:
Here's a video demonstrating it in case you have no clue what I'm talking about.
The problem is I have no idea how to accomplish this. I know that we can set rules to style other elements when hovering another element (link 1, link 2) but I don't know if it's possible for the scrollbar.