Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #64

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Some improvements #64

merged 4 commits into from
Feb 13, 2023

Conversation

hohaicongthuan
Copy link
Contributor

What's changed:

  • Improve window title bar buttons (colours, gradient colours).
  • Add rules to highlight the scrollbar thumb and buttons when hovering over it.
  • Add rules to style hyperlink.

About the scrollbar buttons

The scrollbar buttons in Windows 7 behave like this:

  • In normal state, the button is shaded totally flat.
  • When hovering over the scrollbar (could be the thumb or the track), the button shades will appear.

Here's a video demonstrating it in case you have no clue what I'm talking about.

The problem is I have no idea how to accomplish this. I know that we can set rules to style other elements when hovering another element (link 1, link 2) but I don't know if it's possible for the scrollbar.

Add rules to highlight scrollbar thumb and buttons when hovering over it.
@vercel
Copy link

vercel bot commented Feb 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
7css ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 12, 2023 at 1:24PM (UTC)

Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work, thanks a bunch mate. 2 points to address though.

Reg. the scrollbar, it might not be possible since there has never been a consolidated approach to style it properly across the browsers, it always feels hacky to do it, so feel free to play around with it as you see fit.

gui/_global.scss Outdated
Comment on lines 32 to 39
a {
text-decoration: none;
}

a:hover {
text-decoration: underline;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a hyperlink rule available with _typography.scss. Could you please help move this over there? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm on it.

gui/_global.scss Outdated
Comment on lines 122 to 123
var(--button-shade-light-default) 45%,
var(--button-shade-light-active) 45%
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color tone is too strong in comparison with the video. Feel free to declare a new variable and use a different color to apply here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

gui/_global.scss Outdated
Comment on lines 132 to 133
var(--button-shade-light-default) 45%,
var(--button-shade-light-active) 45%
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

- Fixed scrollbar colours.
- Added rules to style active scrollbar.
@hohaicongthuan
Copy link
Contributor Author

Turns out I used the wrong variables. It's all good now.

Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks mate.

@khang-nd khang-nd merged commit c129fae into khang-nd:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants