switch to use jdk's dateformatter #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add ConfigManager 2. Reference/Service hold reference of ConfigCenterConfig 3. change from-spring to include-spring-env
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java # dubbo-demo/dubbo-demo-api/dubbo-demo-api-provider/src/main/java/org/apache/dubbo/demo/provider/DemoServiceImpl.java
…Config and remove RegistryDataConfig (apache#3129)
…ties format 'dubbo.metadata-report.address=XXx' (apache#3138) * fix apache#3124 . move RegistryDataConfig configuration into RegistryConfig and remove RegistryDataConfig * fix apache#3123. support metadata xml configuration; support configuration format dubbo.metadata-report.address=xxx
…hypher case instead of camel case.
…void dup refresh for registry config. * avoid dup refresh for registry config * fix unit test * fix unit test, org.apache.dubbo.config.AbstractInterfaceConfig#convertRegistryIdsToRegistries generates invalid registry config * should not give RegistryConfig a default value 'RegistryConfig.NO_AVAILABLE'
remove checkApplication for it is invoked before.
* some optimize on ExtensionLoader * make ci rerun * fix compile error * fix ci failure
…e#3363) * reExport fail fix#900 * modify * use Objects.equals * compare URL for all proxy protocol
* Fix self assignment * Replace set with list to insure item order * Minor tweak of codestyle
…d address". (apache#3317) * Fix apache#2423, Multicast demo fails with message "Can't assign requested address" * temporarily disable ipv6 test
* enhance unit test and logging * enhance logging message * fix unit test * make code clean
* polishing LoggerFactory * polishing code using map.computeIfAbsent * fix ci failure * remove unnecessary break in switch * call overloaded method * update as requested * add unit test
* Fix license issues * revert change to Netty's copyright
…pache#936 (apache#3375) * fix dubbo启动脚本中nc命令不稳定 apache#936 * modify
1, remove priority field, the same as super class 2, remove getUrl method, the same as super class 3, refactor constructor, extract method: getRule, getEngine 4, refactor route, extract method: createBindings, getRoutedInvokers
…khanimteyaz/incubator-dubbo into khanimteyaz-acesslog-dateformat-enhancemnet
6 tasks
khanimteyaz
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
switch to use jdk's dateformatter. It is safe to use singleton date formatter since it runs on one single thread only.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.