Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Square brackets in filename issue #66

Closed
RobMeerwijk opened this issue Feb 22, 2021 · 3 comments
Closed

Square brackets in filename issue #66

RobMeerwijk opened this issue Feb 22, 2021 · 3 comments

Comments

@RobMeerwijk
Copy link

RobMeerwijk commented Feb 22, 2021 •
edited
Loading

Hi, I found an issue in mp3fs version 1.1 that I never experienced in the debian package (0.91). If a filename has a '[' or a ']' in it, the file shows up (e.g. in rsync) but cannot be listed, copied or accessed. Lots of media flac files have these brackets.

rsync output:
file has vanished: "/volume1/mp3fs/Alessandro Safina/Insieme a Te [14 Tracks]/09 Alessandro Safina Insieme a Te.mp3"

I reverted to version 1.0. This release handles the filenames without problem.

Thanks for the great work. And now using docker I run mp3fs directly on the NAS without the need of an external raspberry pi for transcoding!
@RobMeerwijk RobMeerwijk changed the title Square brackets in filename issue in docker-version Square brackets in filename issue Feb 23, 2021
khenriks added a commit that referenced this issue Mar 8, 2021
@khenriks
Fix source path determination for transcoding
3b410b8 
Using a glob for this logic does not work well, because certain common
characters like square brackets get interpreted specially. Instead, we
need to just implement the prefix checking ourselves.

This also updates the tests to catch this particular problem.

Fixes #66.
@khenriks
Copy link
Owner

khenriks commented Mar 8, 2021

Wow, that's a pretty embarrassing error. Sorry about that. I think I have a fix, and I've just pushed it to Docker with the 1.1-fix66 tag. Can you try it out and see if it works for you?

@RobMeerwijk
Copy link
Author

fixed! and i don't think it is embarrasing. making an error proves that you are only human! thanks for the fix!

@khenriks
Copy link
Owner

khenriks commented Mar 9, 2021

I'm glad it worked for you! I also made a new release (1.1.1) and pushed it to Docker hub to make the fix official.

@khenriks khenriks mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khenriks @RobMeerwijk