feat(plugin-release): support configuring commit types that count as …

…code changes
kherock · Aug 14, 2021 · 5d130e1 · 5d130e1
1 parent b8c22fd
commit 5d130e1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/plugin-release/sources/commands/release.ts b/packages/plugin-release/sources/commands/release.ts
@@ -79,7 +79,7 @@ export default class ReleaseCommand extends BaseCommand {
       if (requiresVersion && !this.firstRelease) {
         const recommendedStrategy = await recommendedBump(workspace, {prerelease: this.prerelease !== false, preid});
         if (!recommendedStrategy) {
-          report.reportWarning(MessageName.UNNAMED, `No commits since last release`);
+          report.reportWarning(MessageName.UNNAMED, `No code changes since last release`);
           return;
         }
         const version = new SemVer(workspace.locator.reference);

diff --git a/packages/plugin-release/sources/index.ts b/packages/plugin-release/sources/index.ts
@@ -9,6 +9,7 @@ export {releaseUtils};
 declare module "@yarnpkg/core" {
   interface ConfigurationValueMap {
     releaseCalverFormat: string;
+    releaseCodeChangeTypes: Array<string>;
     conventionalChangelogPreset: string;
   }
 }
@@ -20,6 +21,12 @@ const plugin: Plugin = {
       type: SettingsType.STRING,
       default: `YY.MM.micro`,
     },
+    releaseCodeChangeTypes: {
+      description: `A list of commit types that correlate to code changes. Types outside of this set will not generate new releases.`,
+      isArray: true,
+      type: SettingsType.STRING,
+      default: [`feat`, `fix`, `perf`, `refactor`],
+    },
     conventionalChangelogPreset: {
       description: `A preset value to pass to conventional-changelog-preset-loader`,
       type: SettingsType.STRING,

diff --git a/packages/plugin-release/sources/releaseUtils.ts b/packages/plugin-release/sources/releaseUtils.ts
@@ -57,6 +57,7 @@ export async function recommendedBump(workspace: Workspace, {prerelease, preid}:
 
   const conventionalChangelogPreset = project.configuration.get(`conventionalChangelogPreset`);
   const releaseCalverFormat = project.configuration.get(`releaseCalverFormat`);
+  const releaseCodeChangeTypes = new Set(project.configuration.get(`releaseCodeChangeTypes`));
 
   const conventionalRecommendedBumpPromise = promisify<
     conventionalRecommendedBump.Options,
@@ -77,8 +78,7 @@ export async function recommendedBump(workspace: Workspace, {prerelease, preid}:
       skipUnstable: !prerelease,
       lernaPackage: structUtils.stringifyIdent(workspace.locator),
       whatBump: commits => {
-        const codeChanges = new Set([`feat`, `fix`, `perf`, `refactor`, `revert`]);
-        const shouldBump = commits.some(commit => codeChanges.has(commit.type!));
+        const shouldBump = commits.some(commit => releaseCodeChangeTypes.has(commit.type!));
         return recommendedBumpOpts?.whatBump && shouldBump
           ? recommendedBumpOpts.whatBump(commits)
           : {};