v1.15.0 to fix _parseURL() bug

### Releases v1.15.0 1. Fix `_parseURL()` bug. Check [Bug with _parseURL() #21](khoih-prog/AsyncHTTPSRequest_Generic#21) 2. Improve `README.md` so that links can be used in other sites, such as `PIO`
khoih-prog · Feb 1, 2023 · 84236ad · 84236ad
1 parent b441b56
commit 84236ad
Show file tree

Hide file tree

Showing 10 changed files with 186 additions and 152 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -37,7 +37,7 @@ Arduino IDE version: 1.8.19
 ESP32S3_DEV board
 ESP32 core v2.0.6
 OS: Ubuntu 20.04 LTS
-Linux xy-Inspiron-3593 5.15.0-57-generic #63~20.04.1-Ubuntu SMP Wed Nov 30 13:40:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
+Linux xy-Inspiron-3593 5.15.0-58-generic #64~20.04.1-Ubuntu SMP Fri Jan 6 16:42:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
 
 Context:
 I encountered a crash while using this library

diff --git a/README.md b/README.md
diff --git a/changelog.md b/changelog.md
@@ -17,6 +17,7 @@
 ## Table of Contents
 
 * [Changelog](#changelog)
+	* [Releases v1.15.0](#releases-v1150)
 	* [Releases v1.14.0](#releases-v1140)
 	* [Releases v1.13.0](#releases-v1130)
 	* [Releases v1.12.0](#releases-v1120)
@@ -26,6 +27,11 @@
 
 ## Changelog
 
+### Releases v1.15.0
+
+1. Fix `_parseURL()` bug. Check [Bug with _parseURL() #21](https://github.com/khoih-prog/AsyncHTTPSRequest_Generic/issues/21)
+2. Improve `README.md` so that links can be used in other sites, such as `PIO`
+
 ### Releases v1.14.0
 
 1. Add support to `ESP32` and `ESP32S2/S3/C3` boards using `LwIP W6100 Ethernet`

diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
   "name":"AsyncHTTPRequest_ESP32_Ethernet",
-  "version": "1.14.0",
+  "version": "1.15.0",
   "description":"Simple Async HTTP Request library, supporting GET, POST, PUT, PATCH, DELETE and HEAD, on top of AsyncTCP library for ESP32/S2/S3/C3, WT32_ETH01 (ESP32 + LAN8720), ESP32 using LwIP ENC28J60, W5500, W6100 or LAN8720",
   "keywords":"communication, async, tcp, http, esp32, esp32-s2, esp32-s3, esp32-c3, wt32-eth01, ethernet, w5500, w6100, enc28j60, lan8720, lwip, lwip-ethernet, lwip-enc28j60, lwip-w5500, lwip-lan8720",
   "authors": [
@@ -51,19 +51,19 @@
     {
       "owner": "khoih-prog",
       "name": "WebServer_ESP32_ENC",
-      "version": ">=1.5.1",
+      "version": ">=1.5.3",
       "platforms": ["espressif32"]
     },
     {
       "owner": "khoih-prog",
       "name": "WebServer_ESP32_SC_ENC",
-      "version": ">=1.2.0",
+      "version": ">=1.2.1",
       "platforms": ["espressif32"]
     },
     {
       "owner": "khoih-prog",
       "name": "WebServer_ESP32_W5500",
-      "version": ">=1.5.2",
+      "version": ">=1.5.3",
       "platforms": ["espressif32"]
     },
     {
@@ -75,7 +75,7 @@
     {
       "owner": "khoih-prog",
       "name": "WebServer_ESP32_W6100",
-      "version": ">=1.5.2",
+      "version": ">=1.5.3",
       "platforms": ["espressif32"]
     },
     {

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=AsyncHTTPRequest_ESP32_Ethernet
-version=1.14.0
+version=1.15.0
 author=Bob Lemaire,Khoi Hoang <khoih.prog@gmail.com>
 maintainer=Khoi Hoang <khoih.prog@gmail.com>
 license=GPLv3

diff --git a/platformio/platformio.ini b/platformio/platformio.ini
@@ -42,22 +42,22 @@ lib_deps =
 ;  AsyncTCP@>=1.1.1
 ;  ESPAsync_WiFiManager@>=1.15.1
 ;  WebServer_WT32_ETH01@>=1.5.1
-;  WebServer_ESP32_ENC@>=1.5.1
-;  WebServer_ESP32_SC_ENC@>=1.2.0
-;  WebServer_ESP32_W5500@>=1.5.2
+;  WebServer_ESP32_ENC@>=1.5.3
+;  WebServer_ESP32_SC_ENC@>=1.2.1
+;  WebServer_ESP32_W5500@>=1.5.3
 ;  WebServer_ESP32_SC_W5500@>=1.2.1
-;  WebServer_ESP32_W6100@>=1.5.2
+;  WebServer_ESP32_W6100@>=1.5.3
 ;  WebServer_ESP32_SC_W6100@>=1.2.1
 
 ; PlatformIO 5.x
  me-no-dev/AsyncTCP@>=1.1.1
  khoih-prog/ESPAsync_WiFiManager@>=1.15.1
  khoih-prog/WebServer_WT32_ETH01@>=1.5.1
- khoih-prog/WebServer_ESP32_ENC@>=1.5.1
- khoih-prog/WebServer_ESP32_SC_ENC@>=1.2.0
- khoih-prog/WebServer_ESP32_W5500@>=1.5.2
+ khoih-prog/WebServer_ESP32_ENC@>=1.5.3
+ khoih-prog/WebServer_ESP32_SC_ENC@>=1.2.1
+ khoih-prog/WebServer_ESP32_W5500@>=1.5.3
  khoih-prog/WebServer_ESP32_SC_W5500@>=1.2.1
- khoih-prog/WebServer_ESP32_W6100@>=1.5.2
+ khoih-prog/WebServer_ESP32_W6100@>=1.5.3
  khoih-prog/WebServer_ESP32_SC_W6100@>=1.2.1
 
 ; ============================================================

diff --git a/src/AsyncHTTPRequest_ESP32_Ethernet.h b/src/AsyncHTTPRequest_ESP32_Ethernet.h
@@ -18,12 +18,14 @@
   You should have received a copy of the GNU General Public License along with this program.
   If not, see <https://www.gnu.org/licenses/>.
 
-  Version: 1.13.0
+  Version: 1.15.0
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
   1.12.0   K Hoang     16/12/2022 Initial coding to port to ESP32S3 boards using LwIP W5500 or ENC28J60 Ethernet
   1.13.0   K Hoang     21/12/2022 Add support to ESP32S2/C3 boards using LwIP W5500 or ENC28J60 Ethernet
+  1.14.0   K Hoang     09/01/2023 Add support to `ESP32` and `ESP32S2/S3/C3` boards using `LwIP W6100 Ethernet`
+  1.15.0   K Hoang     01/02/2023 Fix _parseURL() bug
  *****************************************************************************************************************************/
 
 #pragma once

diff --git a/src/AsyncHTTPRequest_ESP32_Ethernet.hpp b/src/AsyncHTTPRequest_ESP32_Ethernet.hpp
@@ -18,12 +18,14 @@
   You should have received a copy of the GNU General Public License along with this program.
   If not, see <https://www.gnu.org/licenses/>.
 
-  Version: 1.13.0
+  Version: 1.15.0
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
   1.12.0   K Hoang     16/12/2022 Initial coding to port to ESP32S3 boards using LwIP W5500 or ENC28J60 Ethernet
   1.13.0   K Hoang     21/12/2022 Add support to ESP32S2/C3 boards using LwIP W5500 or ENC28J60 Ethernet
+  1.14.0   K Hoang     09/01/2023 Add support to `ESP32` and `ESP32S2/S3/C3` boards using `LwIP W6100 Ethernet`
+  1.15.0   K Hoang     01/02/2023 Fix _parseURL() bug
  *****************************************************************************************************************************/
 
 #pragma once
@@ -33,13 +35,13 @@
 
 ////////////////////////////////////////
 
-#define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION            "AsyncHTTPRequest_ESP32_Ethernet v1.13.0"
+#define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION            "AsyncHTTPRequest_ESP32_Ethernet v1.15.0"
 
 #define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION_MAJOR      1
-#define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION_MINOR      13
+#define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION_MINOR      15
 #define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION_PATCH      0
 
-#define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION_INT        1013000
+#define ASYNC_HTTP_REQUEST_ESP32_ETHERNET_VERSION_INT        1015000
 
 ////////////////////////////////////////
 

diff --git a/src/AsyncHTTPRequest_ESP32_Ethernet_Debug.h b/src/AsyncHTTPRequest_ESP32_Ethernet_Debug.h
@@ -18,12 +18,14 @@
   You should have received a copy of the GNU General Public License along with this program.
   If not, see <https://www.gnu.org/licenses/>.
 
-  Version: 1.13.0
+  Version: 1.15.0
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
   1.12.0   K Hoang     16/12/2022 Initial coding to port to ESP32S3 boards using LwIP W5500 or ENC28J60 Ethernet
   1.13.0   K Hoang     21/12/2022 Add support to ESP32S2/C3 boards using LwIP W5500 or ENC28J60 Ethernet
+  1.14.0   K Hoang     09/01/2023 Add support to `ESP32` and `ESP32S2/S3/C3` boards using `LwIP W6100 Ethernet`
+  1.15.0   K Hoang     01/02/2023 Fix _parseURL() bug
  *****************************************************************************************************************************/
 
 #pragma once

diff --git a/src/AsyncHTTPRequest_ESP32_Ethernet_Impl.h b/src/AsyncHTTPRequest_ESP32_Ethernet_Impl.h
@@ -18,12 +18,14 @@
   You should have received a copy of the GNU General Public License along with this program.
   If not, see <https://www.gnu.org/licenses/>.
 
-  Version: 1.13.0
+  Version: 1.15.0
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
   1.12.0   K Hoang     16/12/2022 Initial coding to port to ESP32S3 boards using LwIP W5500 or ENC28J60 Ethernet
   1.13.0   K Hoang     21/12/2022 Add support to ESP32S2/C3 boards using LwIP W5500 or ENC28J60 Ethernet
+  1.14.0   K Hoang     09/01/2023 Add support to `ESP32` and `ESP32S2/S3/C3` boards using `LwIP W6100 Ethernet`
+  1.15.0   K Hoang     01/02/2023 Fix _parseURL() bug
  *****************************************************************************************************************************/
 
 #pragma once
@@ -1178,11 +1180,28 @@ bool  AsyncHTTPRequest::_parseURL(const String& url)
 
   int pathBeg = url.indexOf('/', hostBeg);
 
+  int hostEnd;
+  int portBeg;
+
   if (pathBeg < 0)
-    return false;
+  {
+    if ( url.indexOf(':', hostBeg) < 0 )
+    {
+      // No port, just https://www.aaa.com
+      hostEnd = url.length();
+    }
+    else
+    {
+      // with port, https://www.aaa.com:443
+      hostEnd = url.indexOf(':', hostBeg);
+    }
+  }
+  else
+  {
+    hostEnd = pathBeg;
+  }
 
-  int hostEnd = pathBeg;
-  int portBeg = url.indexOf(':', hostBeg);
+  portBeg = url.indexOf(':', hostBeg);
 
   if (portBeg > 0 && portBeg < pathBeg)
   {