Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Fix "blank new line in chunk" bug #50

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

1618033
Copy link
Contributor

@1618033 1618033 commented Nov 30, 2022

If a chunk contains an empty line ("\r\n") chunkLength will be 0 and _setReadyState(readyStateDone) will be called, resulting in truncated payloads. We actually need to wait for "0\r\n" to set state as done.

If a chunk contains an empty line ("\r\n") chunkLength will be 0 and _setReadyState(readyStateDone) will be called, resulting in truncated payloads. We actually need to wait for "0\r\n" to set state as done.
@khoih-prog khoih-prog merged commit ce452fb into khoih-prog:master Nov 30, 2022
@khoih-prog
Copy link
Owner

HI @1618033

Thanks for the PR, which is merged now. Looking forward to receiving more of your bug-fixes and PRs

Best Regards,

khoih-prog added a commit that referenced this pull request Nov 30, 2022
### Releases v1.12.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](#50)
khoih-prog added a commit that referenced this pull request Nov 30, 2022
### Releases v1.12.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](#50)
khoih-prog added a commit that referenced this pull request Nov 30, 2022
### Releases v1.12.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](#50)
@khoih-prog
Copy link
Owner

Hi @1618033

The new AsyncHTTPRequest_Generic v1.12.0 has just been released. Your contribution is noted in Contributions and Thanks

Best Regards,


Releases v1.12.0

  1. Add support to ESP32 boards using LwIP W5500 Ethernet
  2. Fix bug. Check Fix "blank new line in chunk" bug #50

khoih-prog added a commit to khoih-prog/AsyncHTTPSRequest_Generic that referenced this pull request Dec 1, 2022
### Releases v2.4.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog added a commit to khoih-prog/AsyncHTTPSRequest_Generic that referenced this pull request Dec 1, 2022
### Releases v2.4.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog added a commit to khoih-prog/AsyncHTTPSRequest_Generic that referenced this pull request Dec 1, 2022
### Releases v2.4.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog added a commit to khoih-prog/AsyncHTTPSRequest_Generic that referenced this pull request Dec 1, 2022
### Releases v2.4.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog added a commit to khoih-prog/AsyncHTTPSRequest_Generic that referenced this pull request Dec 1, 2022
### Releases v2.4.0

1. Add support to ESP32 boards using `LwIP W5500 Ethernet`
2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants