-
Notifications
You must be signed in to change notification settings - Fork 97
Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h #38
Comments
@Invento3D Thanks for using the library and your opinion. I won't change as suggested as I don't like to loose the benefit of the current way. Many people are also able to use the library as is. Anyway, in the next release, I'll
|
Sorry, but your target users are not well-experienced C++ developers, but most likely mainly people out of the maker area which will not have as much C++ experience as you may think. Apart from that, only because header-only files have become quite popular in the C++ community does not mean that they are suited for every use case. Please consider either
I'm also not sure why you used so many preprocessor directives instead of just using constants. |
I'll update later with the simple solution similar to this |
### Releases v1.2.0 1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](#38) and [`Support building in PlatformIO PR`](#20). SSee [**HOWTO Fix `Multiple Definitions` Linker Error**](https://github.com/khoih-prog/ESP_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error) 2. Fix bug [/close does not close the config portal](khoih-prog/ESPAsync_WiFiManager#16).
### Releases v1.2.0 1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](#38) and [`Support building in PlatformIO PR`](#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESP_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error) 2. Fix bug [/close does not close the config portal](khoih-prog/ESPAsync_WiFiManager#16).
See ESP_WiFiManager v1.2.0 and Contributions-and-Thanks Releases v1.2.0
|
### Releases v1.2.0 1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](khoih-prog/ESP_WiFiManager#38) and [`Support building in PlatformIO PR`](khoih-prog/ESP_WiFiManager#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESPAsync_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error) 2. Fix bug [/close does not close the config portal](#16).
### Releases v1.2.0 1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](khoih-prog/ESP_WiFiManager#38) and [`Support building in PlatformIO PR`](khoih-prog/ESP_WiFiManager#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESPAsync_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error) 2. Fix bug [/close does not close the config portal](#16).
### Releases v1.2.0 1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](khoih-prog/ESP_WiFiManager#38) and [`Support building in PlatformIO PR`](khoih-prog/ESP_WiFiManager#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESPAsync_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error) 2. Fix bug [/close does not close the config portal](#16).
I had a lot of problems integrating your library into my code, mainly because of the strange way of using an ESP_WiFiManager-Impl.h file instead of a .cpp file.
I got the same errors as described in this pull request --> a lot of
multiple definition
errors.I suggest that you change that, since most people are not used to this.
The text was updated successfully, but these errors were encountered: