Work around panic in tokio::time::sleep() #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user showed a stack trace of a crash that resulted from the key-value background task attempting to sleep forever by passing a large Duration. The example the user was running doesn't use expiration at all, so the loop is meant to sleep forever. I'm uncertain what is causing this to panic on their machine and not on any of the test environments I've run on except that they're on Windows. The tokio code as far as I can tell has no platform-specific code in that area, so I'm baffled. I reported tokio-rs/tokio#4494. In the meantime, I've changed the logic to support a "Never" sleep target which avoids calling sleep() when there's no expiration target. This makes the code a little more complicated (the reason I went with the original approach), but it should fix the panic the user was seeing.
ecton
force-pushed
the
key-value-sleep-fix
branch
from
27ac3aa to
874dbe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user showed a stack trace of a crash that resulted from the key-value
background task attempting to sleep forever by passing a large Duration.
The example the user was running doesn't use expiration at all, so the
loop is meant to sleep forever.
I'm uncertain what is causing this to panic on their machine and not on
any of the test environments I've run on except that they're on Windows.
The tokio code as far as I can tell has no platform-specific code in
that area, so I'm baffled. I reported tokio-rs/tokio#4494.
In the meantime, I've changed the logic to support a "Never" sleep
target which avoids calling sleep() when there's no expiration target.
This makes the code a little more complicated (the reason I went with
the original approach), but it should fix the panic the user was seeing.