-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to list a collection's Headers without the document contents #221
Conversation
Still WIP. Confused about what to implement next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you feel is missing from the issue? Other than the unit test not verifying the output, I think this completes all the requirements in the issue?
Ah, after running the CI, I see this error: no method named `headers` found for struct `connection::List` in the current scope This is telling you that you need to add a method named headers to |
I introduced a typo in commit message by mistake. It should be Write test for list_headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the code looks good at first glance, but the CI is failing to compile with this error:
error[E0308]: mismatched types
Error: --> crates/bonsaidb-core/src/connection.rs:961:60
|
961 | .list_headers::<Cl, _, _>(range, sort, limit)
| ^^^^^ expected `usize`, found `u32`
|
= note: expected enum `std::option::Option<usize>`
found enum `std::option::Option<u32>`
707e917
to
20800e6
Compare
Closes #193.