Fix typo in split string length check (feast-dev#464)

khorshuheng · Feb 13, 2020 · ee7b6e5 · ee7b6e5
1 parent 9111b0a
commit ee7b6e5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/sdk/java/src/main/java/com/gojek/feast/RequestUtil.java b/sdk/java/src/main/java/com/gojek/feast/RequestUtil.java
@@ -61,7 +61,7 @@ public static List<FeatureReference> createFeatureRefs(
                   "Feature id '%s' contains invalid version. Expected format: <project>/<feature-name>:<feature-version>.",
                   featureRefString));
         }
-      } else if (projectSplit.length == 1) {
+      } else if (featureSplit.length == 1) {
         name = featureSplit[0];
       } else {
         throw new IllegalArgumentException(

diff --git a/sdk/java/src/test/java/com/gojek/feast/RequestUtilTest.java b/sdk/java/src/test/java/com/gojek/feast/RequestUtilTest.java
@@ -60,7 +60,7 @@ private static Stream<Arguments> provideValidFeatureIds() {
             Arrays.asList(
                 "driver_project/driver_id:1",
                 "driver_project/driver_name:1",
-                "booking_project/driver_name:1"),
+                "booking_project/driver_name"),
             Arrays.asList(
                 FeatureReference.newBuilder()
                     .setProject("driver_project")
@@ -74,7 +74,6 @@ private static Stream<Arguments> provideValidFeatureIds() {
                     .build(),
                 FeatureReference.newBuilder()
                     .setProject("booking_project")
-                    .setVersion(1)
                     .setName("driver_name")
                     .build())));
   }