[breaking] Loosen Sync requirements
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `Send` and `Sync` already control access to `LazyTransform` enough to ensure soundness, there is no need to require it on most methods. This change also enables much more versatile use of lazy-init in less-threaded applications.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this crate! It's exactly what I need for my web framework project.
However, I'm hitting a few snags related to
Syncbounds on various methods, which aren't necessary with appropriate constraints on this type'sunsafe impl Sync. This pull request removes them where possible and as such closes #10.Note that this is unrelated to #9, which I'll make a separate pull request for in a moment.