Skip to content

Commit

Permalink
Managed-by should only be set by helm or similar at install time (#294
Browse files Browse the repository at this point in the history
)

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
  • Loading branch information
bleggett authored Oct 30, 2024
1 parent f0eb4e5 commit e73c85b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ clean:
i386) arch="386" ;; \
i686) arch="386" ;; \
x86_64) arch="amd64" ;; \
arm|arm64) dpkg --print-architecture | grep -q "arm64" && arch="arm64" || arch="arm" ;; \
arm) arch="arm" ;; \
arm64|aarch64) arch="arm64" ;; \
esac ;\
cd "${OUTDIR}/helm-install" ;\
curl -L "https://get.helm.sh/helm-${HELM_VERSION}-$${os}-$${arch}.tar.gz" > "${OUTDIR}/helm-install/helm.tar.gz" ;\
Expand Down
1 change: 0 additions & 1 deletion kiali-operator/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ app: {{ include "kiali-operator.name" . }}
version: {{ .Chart.AppVersion | quote }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
app.kubernetes.io/part-of: "kiali-operator"
{{- end }}

Expand Down
1 change: 0 additions & 1 deletion kiali-server/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ app: kiali
{{ include "kiali-server.selectorLabels" . }}
version: {{ .Values.deployment.version_label | default .Chart.AppVersion | quote }}
app.kubernetes.io/version: {{ .Values.deployment.version_label | default .Chart.AppVersion | quote }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
app.kubernetes.io/part-of: "kiali"
{{- end }}

Expand Down

0 comments on commit e73c85b

Please sign in to comment.