Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Bump node-sass to 5.0 #2135

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Bump node-sass to 5.0 #2135

merged 1 commit into from
Apr 29, 2021

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented Apr 29, 2021

Bumps node-sass version to 5.0. Prior versions of node sass do not compile on systems without python2 due to this issue.

@nrfox nrfox requested a review from israel-hdez April 29, 2021 14:28
@nrfox nrfox self-assigned this Apr 29, 2021
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, just a dev dependency. I guess what you are saying is that without this we required Python 2 to build?

@nrfox
Copy link
Contributor Author

nrfox commented Apr 29, 2021

Seems fine, just a dev dependency. I guess what you are saying is that without this we required Python 2 to build?

Yes exactly. If you alias python=python3 you should see this same issue if you've got Python 2 on your system.

Copy link
Contributor

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I invoked

yarn && yarn build && yarn start

It works. As long as it works, I'm happy :-)

@jshaughn
Copy link
Contributor

@nrfox You can merge this, as just a change to dev deps it does not require QE.

@nrfox nrfox merged commit 34d62d2 into kiali:master Apr 29, 2021
@ghost ghost added this to the v1.34.0 milestone Apr 29, 2021
@nrfox nrfox deleted the bump-node-sass branch April 29, 2021 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants