Skip to content

Commit

Permalink
[ML] Fixing edit calendar locator (elastic#200681)
Browse files Browse the repository at this point in the history
Fixing a typo in the ML locator switch statement which is missing a
`break` for the edit calendar page.
Bug introduced in elastic#193605

Currently there are no instances where the locator is used to find this
page, so this is not something which will affect the user, but it needs
still fixing.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

(cherry picked from commit 2d970dc)
  • Loading branch information
jgowdyelastic committed Nov 19, 2024
1 parent 1cd1b5c commit 4bee84c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions x-pack/plugins/ml/public/locator/ml_locator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export class MlLocatorDefinition implements LocatorDefinition<MlLocatorParams> {
break;
case ML_PAGES.CALENDARS_EDIT:
path = formatEditCalendarUrl('', params.pageState);
break;
case ML_PAGES.CALENDARS_DST_EDIT:
path = formatEditCalendarDstUrl('', params.pageState);
break;
Expand Down

0 comments on commit 4bee84c

Please sign in to comment.