[CI] For PRs, build TS refs before public api docs check (elastic#100791

) (elastic#101128) Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
kibanamachine · Jun 2, 2021 · 4f07817 · 4f07817
1 parent e044137
commit 4f07817
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 23 deletions.
diff --git a/.ci/Jenkinsfile_baseline_capture b/.ci/Jenkinsfile_baseline_capture
@@ -37,7 +37,7 @@ kibanaPipeline(timeoutMinutes: 210) {
                   tasks([
                     kibanaPipeline.functionalTestProcess('oss-baseline', './test/scripts/jenkins_baseline.sh'),
                     kibanaPipeline.functionalTestProcess('xpack-baseline', './test/scripts/jenkins_xpack_baseline.sh'),
-                    kibanaPipeline.scriptTask('Check Public API Docs', 'test/scripts/checks/plugin_public_api_docs.sh'),
+                    kibanaPipeline.scriptTask('Check Public API Docs', 'test/scripts/checks/baseline_plugin_public_api_docs.sh'),
                   ])
                 }
               }

diff --git a/test/scripts/checks/baseline_plugin_public_api_docs.sh b/test/scripts/checks/baseline_plugin_public_api_docs.sh
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+source src/dev/ci_setup/setup_env.sh
+
+###
+### rebuild plugin api docs to ensure it's not out of date
+###
+echo " -- building api docs"
+node scripts/build_api_docs
diff --git a/test/scripts/checks/plugin_public_api_docs.sh b/test/scripts/checks/plugin_public_api_docs.sh
diff --git a/test/scripts/checks/type_check.sh → ...ecks/type_check_plugin_public_api_docs.sh b/test/scripts/checks/type_check.sh → ...ecks/type_check_plugin_public_api_docs.sh
@@ -12,3 +12,6 @@ checks-reporter-with-killswitch "Build TS Refs" \
 
 checks-reporter-with-killswitch "Check Types" \
   node scripts/type_check
+
+echo " -- building api docs"
+node scripts/build_api_docs
diff --git a/vars/tasks.groovy b/vars/tasks.groovy
@@ -11,8 +11,7 @@ def check() {
     kibanaPipeline.scriptTask('Check Doc API Changes', 'test/scripts/checks/doc_api_changes.sh'),
     kibanaPipeline.scriptTask('Check @kbn/pm Distributable', 'test/scripts/checks/kbn_pm_dist.sh'),
     kibanaPipeline.scriptTask('Check Plugin List Docs', 'test/scripts/checks/plugin_list_docs.sh'),
-    kibanaPipeline.scriptTask('Check Public API Docs', 'test/scripts/checks/plugin_public_api_docs.sh'),
-    kibanaPipeline.scriptTask('Check Types', 'test/scripts/checks/type_check.sh'),
+    kibanaPipeline.scriptTask('Check Types and Public API Docs', 'test/scripts/checks/type_check_plugin_public_api_docs.sh'),
     kibanaPipeline.scriptTask('Check Bundle Limits', 'test/scripts/checks/bundle_limits.sh'),
     kibanaPipeline.scriptTask('Check i18n', 'test/scripts/checks/i18n.sh'),
     kibanaPipeline.scriptTask('Check File Casing', 'test/scripts/checks/file_casing.sh'),