Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1763] add redeem and pledge redemption survey deeplinks #2147

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Oct 7, 2024

📲 What

Added the URIs for our URI parser to recognize and open deeplinsk for project surveys for redeem/pledge_redemption

🤔 Why

These links will need to be supported in order to use the new web pages for pledge redemption

🛠 How

Added the link patters for

  • .../projects/:creator_param/:project_param/backing/pledge_redemption
  • ...//projects/:creator_param/:project_param/backing/redeem
    in the uri parser

📋 QA

-Have an account with a pledge redemption backing or create a project for testing and back it

  • Have the project send pledge redemption surveys
  • confirm the deeplinks work

Story 📖

MBL-1763

@mtgriego mtgriego self-assigned this Oct 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.52%. Comparing base (0e8181e) to head (36b6423).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2147      +/-   ##
============================================
+ Coverage     67.51%   67.52%   +0.01%     
- Complexity     2227     2230       +3     
============================================
  Files           368      368              
  Lines         22899    22905       +6     
  Branches       3294     3296       +2     
============================================
+ Hits          15460    15467       +7     
  Misses         5684     5684              
+ Partials       1755     1754       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtgriego mtgriego marked this pull request as ready for review October 7, 2024 22:49
@mtgriego mtgriego merged commit b891f29 into master Oct 8, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-1763 branch October 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants