Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve argument info definitions #9

Merged
merged 4 commits into from
Dec 23, 2021
Merged

Improve argument info definitions #9

merged 4 commits into from
Dec 23, 2021

Conversation

cs278
Copy link
Member

@cs278 cs278 commented Dec 23, 2021

This lays the groundwork to fix the missing argument/return types in PHP 8+.

  • Move arginfo structures in to their own file
  • Simplify cases which have the same function definition
  • Refactor version based skipping to be more flexible
  • Add distinct method definitions

@cs278 cs278 self-assigned this Dec 23, 2021
This is in preparation for PHP 8 as the constructors would break if
aliased to the functions due to the return types beind added to the
functions.

Initially these are aliases but for PHP 8 they will be overridden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant