-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlayerInfo functionality #1
base: master
Are you sure you want to change the base?
Conversation
kunalpowar
commented
Jun 8, 2014
- also added a few glogs to enable debugging
type A2SPlayerRequest struct { | ||
} | ||
|
||
func (A2SPlayerRequest) MarshalBinaryFromChallenge(c ChallengeResponse) ([]byte) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MarshalBinary is from http://tip.golang.org/pkg/encoding/#BinaryMarshaler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the A2SPlayerRequest should be instantiated with the ChallengeResponse, and not passed to this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get the marshalBinary part. But Why should A2SPlayerRequest know Challenge Response. It is built using a challenge Response. The request itself need not have the challenge as a separate entity. In fact the first implementation had something like
type A2SPlayerRequest struct {
c ChallengeResponse
}
thanks for the PR. we definitely needed this
|
Thanks for the feedback. Am still in progress of cleaning up the code. Will solve the issues you pointed out. |