Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 return pipefail #16

Merged
merged 1 commit into from
May 20, 2024
Merged

🔧 return pipefail #16

merged 1 commit into from
May 20, 2024

Conversation

dmiller15
Copy link
Collaborator

Description

My attempt to clean up this tool and re-add the pipefail.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 added bug Something isn't working bix-dev labels May 17, 2024
@dmiller15 dmiller15 requested a review from migbro May 17, 2024 21:26
@dmiller15 dmiller15 self-assigned this May 17, 2024
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated! Seems top be a hybrid of going back to having the single quote done within the js and putting the code in a shell script so that pipefail works properly. Thanks for helping to make this a more robust tool!

@migbro migbro merged commit 9b27571 into bug/mb-fix-hard-filter May 20, 2024
1 check passed
@migbro migbro deleted the dm-return-pipefail branch May 20, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants