Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 JG submodules now init #18

Merged
merged 1 commit into from
May 21, 2024
Merged

🐛 JG submodules now init #18

merged 1 commit into from
May 21, 2024

Conversation

dmiller15
Copy link
Collaborator

Description

The GHA was not initializing the annotation submodule in joint-genotyping. Added flag to enable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested the commands locally but no way to know for sure if this will work until we try it.

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 added bug Something isn't working bix-dev labels May 21, 2024
@dmiller15 dmiller15 self-assigned this May 21, 2024
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔛

@migbro migbro self-requested a review May 21, 2024 17:39
@dmiller15 dmiller15 merged commit 9d7193c into master May 21, 2024
1 check passed
@dmiller15 dmiller15 deleted the dm-fix-gha-submodule-init branch May 21, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants