🔧 Increase max and default page limits #629
Conversation
See yaml/pyyaml#724 for details
znatty22
force-pushed
the
increase-limit-max
branch
from
edd5821
to
d81913f
Compare
znatty22
force-pushed
the
increase-limit-max
branch
2 times, most recently
from
516859b
to
115070b
Compare
znatty22
force-pushed
the
increase-limit-max
branch
from
115070b
to
464900f
Compare
|
|
||
| # Important but *temporary* | ||
| # See https://github.com/yaml/pyyaml/issues/724 | ||
| pip install "cython<3.0.0" && pip install --no-build-isolation "pyyaml==5.4.0" |
There was a problem hiding this comment.
That's an annoying issue. Is there something that we need pyyaml at 5.4.0 for, or can we take a newer version like pyyaml<6.0? Would rather not hard-code a specific version to change later if we can avoid it.
There was a problem hiding this comment.
@devbyaccident Lol that image is so accurate.
We've always had pyyaml pinned to 5.4.0, and I believe its bc a while ago, something broke and caused us to pin it. So I don't want to change anything that we don't absolutely have to in this PR. I can try changing it in another PR so the change isolated
There was a problem hiding this comment.
Gotchya, that makes sense. Ok, I'm happy to give it the 👍 , but I can't speak as much for the non-docker/package changes. Would still like someone from @kids-first/dataservice-reviewers to take a look.
## Release 1.21.0 ### Summary - Emojis: 🔧 x1 - Categories: Ops x1 ### New features and changes - [#629](#629) - 🔧 Increase max and default page limits - [9d38045](9d38045) by [znatty22](https://github.com/znatty22)
Motivation
The kf-api-study-creator API often queries the Dataservice when it syncs studies between Dataservice and itself. Unfortunately there is a bug in study creator where it only ever requests the first 100 studies since this is the maximum # of resources you can fetch in a single request.
Additionally, several other API consumers have long been requesting the maximum page size be increased from 100 to something larger so that they can send less requests.
Approach