Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Remove sync job with old release coordinator #774

Merged
merged 1 commit into from
Sep 30, 2021
Merged

🔥 Remove sync job with old release coordinator #774

merged 1 commit into from
Sep 30, 2021

Conversation

znatty22
Copy link
Member

Closes #773

@znatty22 znatty22 added the refactor Something needs to be done better label Sep 30, 2021
@znatty22 znatty22 self-assigned this Sep 30, 2021
@znatty22 znatty22 marked this pull request as ready for review September 30, 2021 22:05
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #774 (9699242) into master (41e2da2) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   95.01%   95.56%   +0.54%     
==========================================
  Files         172      172              
  Lines        7480     7434      -46     
==========================================
- Hits         7107     7104       -3     
+ Misses        373      330      -43
Impacted Files Coverage Δ
creator/releases/tasks.py 100.00% <ø> (+17.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e2da2...9699242. Read the comment docs.

dankolbman
dankolbman approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕‍🦺

@znatty22 znatty22 merged commit 7b445e8 into master Sep 30, 2021
@znatty22 znatty22 deleted the phase-out-coord-sync branch September 30, 2021 22:48
znatty22 added a commit that referenced this pull request Oct 1, 2021
@znatty22
🏷️ Release 1.19.8
4d09276 
## Release 1.19.8

### Summary

- Emojis: 🐛 x1, 🔥 x1
- Categories: Removals x1, Fixes x1

### New features and changes

- [#772](#772) - 🐛 Fix slack notifications - [4d95618](4d95618) by [znatty22](https://github.com/znatty22)
- [#774](#774) - 🔥 Remove sync job with old release coordinator - [7b445e8](7b445e8) by [znatty22](https://github.com/znatty22)
@znatty22 znatty22 mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankolbman dankolbman dankolbman approved these changes

@gsantia gsantia Awaiting requested review from gsantia

Assignees

@znatty22 znatty22

Labels
refactor Something needs to be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phase out sync job with old release coordinator
2 participants
@znatty22 @dankolbman