Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix study sync f-string #799

Merged
merged 2 commits into from
Nov 11, 2021
Merged

🐛 Fix study sync f-string #799

merged 2 commits into from
Nov 11, 2021

Conversation

gsantia
Copy link
Contributor

@gsantia gsantia commented Nov 10, 2021

A string in the sync studies command file wasn't actually an f-string when it's supposed to be. Fix this and apply black to the file.

@gsantia gsantia added the bug Something isn't working label Nov 10, 2021
@gsantia gsantia self-assigned this Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #799 (01ce99a) into master (348de53) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         172      172           
  Lines        7474     7474           
=======================================
  Hits         7153     7153           
  Misses        321      321           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348de53...01ce99a. Read the comment docs.

@gsantia gsantia merged commit 760d5dc into master Nov 11, 2021
@gsantia gsantia deleted the fix_study_sync branch November 11, 2021 02:30
znatty22 added a commit that referenced this pull request Dec 7, 2021
## Release 1.21.0

### Summary

- Emojis: ✨ x1, 🐛 x1
- Categories: Additions x1, Fixes x1

### New features and changes

- [#789](#789) - ✨ Add short_code, domain, and program to Study - [c13c656](c13c656) by [gsantia](https://github.com/gsantia)
- [#799](#799) - 🐛 Fix study sync f-string - [760d5dc](760d5dc) by [gsantia](https://github.com/gsantia)
@znatty22 znatty22 mentioned this pull request Dec 7, 2021
znatty22 added a commit that referenced this pull request Dec 8, 2021
## Release 1.21.0

### Summary

- Emojis: 🛠 x1, ✨ x1, 🐛 x1
- Categories: Additions x1, Fixes x1, Other Changes x1

### New features and changes

- [#804](#804) - 🛠 Expose content-disposition header in download template reqs - [ff6360a](ff6360a) by [znatty22](https://github.com/znatty22)
- [#789](#789) - ✨ Add short_code, domain, and program to Study - [c13c656](c13c656) by [gsantia](https://github.com/gsantia)
- [#799](#799) - 🐛 Fix study sync f-string - [760d5dc](760d5dc) by [gsantia](https://github.com/gsantia)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants