Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(variant 2): SKFP-772 variant facet and column names #3775

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

AltefrohneGaelle
Copy link
Collaborator

@AltefrohneGaelle AltefrohneGaelle commented Sep 25, 2023

[FEATURE] Variant 2 review all facet names and consequence column

Description

SKFP-772

  • Variant 2 facet name in sidebar menu and in query builder
  • Consequence column name in result table

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

Capture d’écran, le 2023-09-25 à 17 13 41 Capture d’écran, le 2023-09-25 à 17 13 33 Capture d’écran, le 2023-09-25 à 17 13 26 Capture d’écran, le 2023-09-25 à 17 13 16

After

Capture d’écran, le 2023-09-25 à 17 12 08 Capture d’écran, le 2023-09-25 à 17 11 39 Capture d’écran, le 2023-09-25 à 17 12 00 Capture d’écran, le 2023-09-25 à 17 11 50

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit 127cbdf
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/6511f81ac1d76f000874eecf
😎 Deploy Preview https://deploy-preview-3775--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit 127cbdf
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/6511f81a8797340008046d9c
😎 Deploy Preview https://deploy-preview-3775--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from 127cbdf

@AltefrohneGaelle AltefrohneGaelle merged commit 887e2c1 into 2.0 Sep 26, 2023
7 checks passed
@AltefrohneGaelle AltefrohneGaelle deleted the feat/SKFP-772-variant-facet-column-name branch September 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants