Fix/skfp 483 #3776
Merged
Fix/skfp 483 #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisl
requested review from
ethienneroy,
celinepelletier and
AltefrohneGaelle
ethienneroy
reviewed
Sep 26, 2023
ethienneroy
reviewed
Sep 26, 2023
francisl
force-pushed
the
fix/skfp-483
branch
from
7e7c3fd
to
f1961d1
Compare
✅ Deploy Preview for portal-pre-prod-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for portal-qa-next-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from 9effe5b |
ethienneroy
approved these changes
Sep 26, 2023
francisl
force-pushed
the
fix/skfp-483
branch
2 times, most recently
from
bd73b0e
to
9728b3a
Compare
AltefrohneGaelle
approved these changes
Sep 26, 2023
francisl
force-pushed
the
fix/skfp-483
branch
from
9728b3a
to
9effe5b
Compare
AltefrohneGaelle
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#BUG/FEATURE
Description
Update Domain as it was recently added to the ETL
Update Domain as it was recently added to the ETL
Update the Checkmarks in the Data Category columns (Genomics, Transcriptomics , Proteomics). If a study have files of Data Category X, then there should be a checkmark
Remove the Clinical column in the table
IMPORTANT REFACTOR
Refactor the whole logic to fetch aggregation. Before it was done for each individual aggregation, one api/graphql call for each. Now its done in batch.
Validation
Screenshot
Before
After
QA
Please check all pages with facets/aggregations
Mention
@kstonge