Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(variants): SKFP-880 update variant table #3873

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

AltefrohneGaelle
Copy link
Collaborator

@AltefrohneGaelle AltefrohneGaelle commented Jan 10, 2024

[FEATURE] Update UI variants table

Description

SKFP-880

Acceptance Criterias

Add the following fields:

  • Separated Gene column with a different redirect
  • MANE
  • OMIM
  • CADD (phred score) (optional column)
  • REVEL (optional column)
  • gnomAD ALT

Modify the following fields:

  • Variant : Freeze this column on the left hand side as users scroll horizontally and the column is hidden
  • Type: Show the abbreviations for the variant type.
  • dbSNP: remove the sort, remove the value and put an icon with redirection
  • Most Deleterious Consequence: remove the gene symbol since it will be represented with the new “Gene” column. Only show the vep_impact, consequence, and AA_change
  • GnomAD : add red circle if the frequency is less than 1%
  • ClinVAr: Show the abbreviations for the ClinVar values
  • Studies: Add tooltip, and sort
  • Part# & Freq# : combine both fields into one
  • Set ALT & Homo. columns as optional, update tooltip

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

Capture d’écran, le 2024-01-10 à 11 10 51

After

Capture d’écran, le 2024-01-10 à 11 08 20

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit e628fd3
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/65a00ba1eb2f7c0007cac64d
😎 Deploy Preview https://deploy-preview-3873--portal-pre-prod-kidsfirstdrc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit e628fd3
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/65a00ba11ca8180008cc1936
😎 Deploy Preview https://deploy-preview-3873--portal-qa-next-kidsfirstdrc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 10, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from e628fd3

const ManeCell = ({ consequence }: OwnProps) => {
const { mane_select, canonical, mane_plus } = consequence;
const haveResult = mane_select || canonical || mane_plus;
return haveResult ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un earlier return serait plus lisible ici

if (!haveResult) return <>TABLE_EMPTY_PLACE_HOLDER</>

@lflangis lflangis self-requested a review January 11, 2024 15:42
@AltefrohneGaelle AltefrohneGaelle merged commit f845b25 into 2.0 Jan 11, 2024
8 checks passed
@AltefrohneGaelle AltefrohneGaelle deleted the feat/SKFP-880-variant-table branch January 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants