-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(variants): SKFP-880 update variant table #3873
Conversation
✅ Deploy Preview for portal-pre-prod-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for portal-qa-next-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from e628fd3 |
src/components/ManeCell/index.tsx
Outdated
const ManeCell = ({ consequence }: OwnProps) => { | ||
const { mane_select, canonical, mane_plus } = consequence; | ||
const haveResult = mane_select || canonical || mane_plus; | ||
return haveResult ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
un earlier return serait plus lisible ici
if (!haveResult) return <>TABLE_EMPTY_PLACE_HOLDER</>
[FEATURE] Update UI variants table
Description
SKFP-880
Acceptance Criterias
Add the following fields:
Modify the following fields:
Validation
Screenshot
Before
After