Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widget): SKFP-918 auth studies style and count #3881

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

AltefrohneGaelle
Copy link
Collaborator

@AltefrohneGaelle AltefrohneGaelle commented Jan 16, 2024

[BUG] Fix Authorized Studies style and count

SKFP-918

Description

Acceptance Criterias

  • incorrect stats count in study item. We want (authorized_controlled_files_count + total_uncontrolled_files_count) of total_files_count
  • Number of study items in the header sticks after fence disconnection. To reproduce, connect with success to a fence, make sure a number is displayed in the header, disconnect the fence, the list of item will empty itself but the count will remain.
  • Wording between header and list cut sometimes.

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

Small screen
Capture d’écran, le 2024-01-16 à 11 58 50

After

Small screen
Capture d’écran, le 2024-01-16 à 16 07 21

Capture d’écran, le 2024-01-16 à 16 07 30

Big screen
Capture d’écran, le 2024-01-16 à 16 08 52

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit 3b79579
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/65a6f110a7e30200083d3e6a
😎 Deploy Preview https://deploy-preview-3881--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit 3b79579
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/65a6f1109f24e30008503366
😎 Deploy Preview https://deploy-preview-3881--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from 3b79579

@AltefrohneGaelle AltefrohneGaelle merged commit 43c1b27 into 2.0 Jan 16, 2024
8 checks passed
@AltefrohneGaelle AltefrohneGaelle deleted the fix/SKFP-918-auth-widget-refactor branch January 16, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants