Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 🧹Update ref pointers, add pure lancet mode, lceanup deprecated #184

Merged
merged 11 commits into from
May 20, 2024

Conversation

migbro
Copy link
Collaborator

@migbro migbro commented May 14, 2024

Description

This started off as a simple refs-pointer update, but since in the near-ish future, we'll be updating Lancet calls, I also updated that functionality and also just deleted a bunch of legacy stuff as clean up. To summarize as a bullet list:

  • Update default sbg file tags
  • Added an input for a user to add existing VCF calls so that Lancet exome+ mode can be run on existing data , instead of having to re-run strelka2 and mutect2 internally
  • Updated the validator logic to look for at least a strelka2/mutect2 internal run or a user to supply vcf files when validating run lancet true
  • Removed a whole bunch of dev and deprecated wfs as they'll exist in old releases if needed
  • Updated README, also updated doc which updated formatting

Fixes # BIXU-3657 and BIXU-3655

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@migbro migbro added bug Something isn't working documentation Adds documentation bix-dev This issue or pull request is bix-dev work labels May 14, 2024
@migbro migbro self-assigned this May 14, 2024
Copy link
Contributor

@dmiller15 dmiller15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for the lancet_input_vcf integration on that supplementary_vcf input. The expression needs to be changed to get all of the VCF rather than just the first one.

migbro and others added 4 commits May 16, 2024 11:29
Co-authored-by: Dan Miller <dmiller15@users.noreply.github.com>
🔨 allow skip calmd if bam input
@migbro migbro requested a review from dmiller15 May 20, 2024 19:14
@migbro
Copy link
Collaborator Author

migbro commented May 20, 2024

@migbro migbro merged commit cdc207e into master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work bug Something isn't working documentation Adds documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants