Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove chrlen chrs not in ballele #192

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dmiller15
Copy link
Contributor

@dmiller15 dmiller15 commented Sep 25, 2024

Description

Changes:

  • Update the awk_chrlen_builder tool to remove CHRs that do not appear in the b_allele file
  • Update interval documentation to reflect this change

Closes https://d3b.atlassian.net/browse/BIXU-3770

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 added bug Something isn't working bix-dev This issue or pull request is bix-dev work labels Sep 25, 2024
@dmiller15 dmiller15 self-assigned this Sep 25, 2024
@dmiller15 dmiller15 marked this pull request as ready for review September 25, 2024 17:00
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the quick turnaround

@dmiller15 dmiller15 merged commit 088ce46 into master Sep 25, 2024
1 check passed
@dmiller15 dmiller15 deleted the dm-controlfreec-addbafinfo-no-y branch September 25, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants