Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-7514 strict JSON parsing with Jackson #64

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

tarilabs
Copy link
Member

ref https://issues.redhat.com/browse/DROOLS-7514

Tested locally by:

Step1: on this project

mvn clean install
cp drools-ansible-rulebook-integration-runtime/target/drools-ansible-rulebook-integration-runtime-1.0.3-SNAPSHOT.jar ../drools_jpy/src/drools/jars/
Screenshot 2023-07-25 at 12 41 56

Step2: on drools_jpy "pretend" an ad-hoc version

pytest -vv -s
python3 -m pip install .
Screenshot 2023-07-25 at 12 41 59

(note: using "same" venv between drools_jpy and ansible-rulebook)

Step3: on ansible-rulebook "pretend" to use the "pretend-drools-jpy-version" and check the same commands per ansible-rulebook CI on GitHub action:

pip install -e .
pip install -r requirements_dev.txt
pytest -m "e2e" -n auto 
pytest -m "not e2e and not long_run" -vv -n auto
Screenshot 2023-07-25 at 12 42 05 Screenshot 2023-07-25 at 12 43 28

(the only 1 failure in the last screenshot is indeed due to the "pretend" version since 0.3.5.1 for the drools_jpy version does not match test assertions, but it;'s fine as it's only a pretend-version for the scope of this manual testing locally across the 3 projects)

Copy link
Collaborator

@tkobayas tkobayas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed instruction. I run the same on my local end :)

@tarilabs
Copy link
Member Author

Double-checked with Ansible rulebook SME on 2023-07-27 and validated for strict JSON (this PR), worst case should be needed in the future would be a matter of re-enabling these lines:

https://github.com/kiegroup/drools-ansible-rulebook-integration/pull/64/files#diff-8f8c08fc25f02a2bc6adf26632d8b7d7a2055eb24ddfe08afad1085c769ea225L20-L23

proceeding to merge.

@tarilabs tarilabs merged commit 18b42a0 into kiegroup:main Jul 28, 2023
tarilabs added a commit to tarilabs/drools-ansible-rulebook-integration that referenced this pull request Jul 31, 2023
mark down notes from
kiegroup#64
in readme
tarilabs added a commit that referenced this pull request Aug 1, 2023
mark down notes from
#64
in readme
mariofusco pushed a commit that referenced this pull request Aug 21, 2023
mariofusco pushed a commit that referenced this pull request Aug 21, 2023
mark down notes from
#64
in readme

(cherry picked from commit 408a112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants