Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRVLOGIC-211] add script to remove modules that should not be in the productized build #11

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[SRVLOGIC-211] add script to remove modules that should not be in the productized build #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions productized/modules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pom.xml;drools-beliefs,drools-traits,drools-verifier,drools-persistence,drools-examples,drools-examples-api,drools-test-coverage,drools-scenario-simulation,drools-metric,drools-impact-analysis,drools-retediagram,drools-fastutil,kie-maven-plugin,kie-archetypes,jpmml-migration-recipe,drools-drlonyaml-parent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should also add the new drools-prototypes to this list. It implements a new feature of drools that we never discussed as being part of the product.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariofusco do you mean module drools-model-prototype from drools-model/pom.xml? This is the only module I could find in the code related to prototypes.

If this is the module you meant, I tried to remove it but the build fails because org.drools:drools-model-codegen depends on org.drools:drools-model-prototype

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the module you meant, I tried to remove it but the build fails because org.drools:drools-model-codegen depends on org.drools:drools-model-prototype

Ah, you're totally right. I will check if I can decouple them and make that dependency optional, but for now I think it is ok to merge this PR as it is then.

kie-drl/kie-drl-implementations/pom.xml;kie-drl-kiesession-local
kie-drl/pom.xml;kie-drl-tests,kie-drl-tests-without-index-file
kie-dmn/pom.xml;kie-dmn-openapi,kie-dmn-tck,kie-dmn-legacy-tests,kie-dmn-trisotech,kie-dmn-signavio,kie-dmn-pmml-tests-parent,kie-dmn-xls2dmn-cli,kie-dmn-core-jsr223-jq,kie-dmn-core-jsr223,kie-dmn-ruleset2dmn-parent
drools-quarkus-extension/pom.xml;drools-quarkus,drools-quarkus-deployment,drools-quarkus-integration-test,drools-quarkus-integration-test-hotreload,drools-quarkus-ruleunit-integration-test,drools-quarkus-quickstart-test,drools-quarkus-examples
28 changes: 28 additions & 0 deletions productized/remove_modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#!/usr/bin/env bash
#
# This script expects a configuration file separated by semicolon, where the first part is the pom and the second the modules to be removed from that pom
# It can be invoked from project root folder using: $ ./productized/remove_modules.sh ./productized/modules

# fast fail
set -e
set -o pipefail

if [ $# -lt 1 ];
then
echo "$0: Missing arguments"
exit
fi

config_file="${1}"
for line in `cat "$config_file"`
do
pom=$(echo $line | cut -d ';' -f1)
modules=$(echo $line | cut -d ';' -f2)

modules_list=$(echo $modules | tr "," "\n")
for module in ${modules_list}
do
echo "Removing module ${module} from ${pom}"
sed -i "/<module>${module}<\/module/d" ${pom}
done
done
Loading