Remove DisCo from transpilation to elkjs because it somehow breaks the CI build #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this confirms that the problem appears to be limited to disco and its CompactionStrategy |
|
Does this mean we remove disco? Or that disco just cannot be transpiled to JavaScript? |
|
Removing it would fix the CI build on Github but since I can still build it locally, I don't think we should jump straight to removing it completely. But it's an option to keep in mind I guess |
|
If I keep re-running the failed runs, eventually they succeed https://github.com/kieler/elkjs/actions/runs/9761341512 |
Eddykasp
changed the title
soerendomroes
requested changes
Jul 3, 2024
| @@ -71,7 +71,7 @@ def elkSources = [ | |||
| "${elkRepo}/plugins/org.eclipse.elk.graph.json/src", | |||
| "${elkRepo}/plugins/org.eclipse.elk.alg.common/src", | |||
| // The algorithms | |||
| "${elkRepo}/plugins/org.eclipse.elk.alg.disco/src", | |||
| //"${elkRepo}/plugins/org.eclipse.elk.alg.disco/src", | |||
There was a problem hiding this comment.
Maybe add a comment why this is not included here and maybe a FIXME to investigate the problem or a link to the issue.
| @@ -24,7 +24,7 @@ | |||
| import org.eclipse.elk.graph.json.*; | |||
|
|
|||
| import org.eclipse.elk.alg.common.compaction.options.*; | |||
| import org.eclipse.elk.alg.disco.options.*; | |||
| //import org.eclipse.elk.alg.disco.options.*; | |||
| @@ -144,8 +144,8 @@ public static void registerLayoutAlgorithms(final JavaScriptObject arrayObj) { | |||
| SERVICE.registerLayoutMetaDataProviders(new MrTreeMetaDataProvider()); | |||
| } else if (alg.equals("radial")) { | |||
| SERVICE.registerLayoutMetaDataProviders(new RadialMetaDataProvider()); | |||
| } else if (alg.equals("disco")) { | |||
| SERVICE.registerLayoutMetaDataProviders(new PolyominoOptions(), new DisCoMetaDataProvider()); | |||
| // } else if (alg.equals("disco")) { | |||
soerendomroes
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.