Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPD? #1

Open
ivicajan opened this issue Sep 21, 2017 · 15 comments
Open

GPD? #1

ivicajan opened this issue Sep 21, 2017 · 15 comments

Comments

@ivicajan
Copy link

Nice tool
I'm working with extreme values for sea level and would like to compare with my genpareto.fit...
It would bi cool if you could add GPD as well, then more/less you have everything.

thanks!
Ivica

@kikocorreoso
Copy link
Owner

Hi,

Yes, it would be cool. Dev has staged and I would like to retake it but I don't know when it will be possible.

If you find the time to make a PR it would be great 😄

@ivicajan
Copy link
Author

ivicajan commented Sep 23, 2017 via email

@kikocorreoso
Copy link
Owner

I've used extRemes in the past. It is robust and powerful. Check it out. But as you said. it is not python.

My idea is to provide an easy API to do the most basic univariate extremes but I need to find time to include GPD.

@zizzipupp
Copy link

Hi, I am not able to install this package. I have tried pip install scikit-extremes but it says that it "Could not find a version that satisfies the requirement scikit-extremes - No matching distribution found for scikit-extremes".

What do you suggest?

@kikocorreoso
Copy link
Owner

@zizzipupp please, comment here #2

@harshagrao
Copy link

Hi, when is the GPD expected to arrive? Currently using extRemes in R but want to switch to python, looking for GPD equivalents :)

@kikocorreoso
Copy link
Owner

@harshagrao There is not expected date.

Maybe this summer I will find some time to work on this but there is no guarantee. If you find some time you can send a PR to include GPD in the library.

@kartikeya13
Copy link

@kikocorreoso Hello

Will your GPD have all those plots which you had in gev(QQ plot, pp plot,
return plot, density)?

@kartikeya13
Copy link

@ivicajan @harshagrao Hello,
Did you guys get gpd for pot python ?

@kartikeya13
Copy link

@ivicajan Can you please help me in knowing how can i fit GPD?

@kikocorreoso
Copy link
Owner

This PR scipy/scipy#9513 could help in the implementation of GPD but it is delayed to review for Scipy v1.4,...

I will have a look to try to implement the relevant funcs in the skextreme's utils module in the meantime if I find some bandwidth.

@kikocorreoso kikocorreoso mentioned this issue Jul 19, 2019
@cosstas
Copy link

cosstas commented Jul 19, 2019

@kikocorreoso Hello,
scipy.signal.find_peaks is a good starting point for peak detection for POT analysis. It has parameters like 'distance' that can already perform some basic 'declustering'.
PR scipy/scipy#9513 I suppose just adds more elaborate 'declustering' methods. POT/GPD fitting can be done without it.

@kikocorreoso
Copy link
Owner

Hi @cosstas

Thanks for the link.

I've analysed that func from scipy but it is not suitable to do declustering "correctly" (e.g., "correctly" in EVA as it is defined in Coles (2001)).

In my message above I've linked new funcs that could be included in scipy in the future. I will check them to see if them can be included directly in skextremes and when they are included in scipy refactor to use them from scipy.

@cosstas
Copy link

cosstas commented Jul 19, 2019

@kikocorreoso I was just trying to streamline your bandwidth allocation. :)
Any built-in peak detection/declustering functionality would be welcome of course, but I think its importance is secondary to the actual Analysis implementation.
In my opinion, POT detection, although necessary, should be independent of the POT analysis because it greatly depends on the estimated quantity. For example POT in sea-wave height timeseries is more complicated than rainfall or temperature.

@kikocorreoso
Copy link
Owner

@cosstas for me would be paramount to provide functionality to choose the correct data, a declustering function, 'correct' threshold selection, mean residual life plot,... I think all this should be included in the package. Until I do not have this i prefer to delay the inclusion of a GPD fit function because for me it is not independent the POT detection from the GPD fit. The POT detection drives the final GPD fit and I prefer to provide tools to help the user on that 😉

In the meantime, of course, all PRs are 🆗 👌 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants