Issue 330 500 error improvement

killbill · May 24, 2024 · e4f8453 · e4f8453
1 parent 7de5226
commit e4f8453
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 0 deletions.
diff --git a/app/controllers/kaui/sessions_controller.rb b/app/controllers/kaui/sessions_controller.rb
@@ -3,12 +3,19 @@
 module Kaui
   # Subclassed to specify the correct layout
   class SessionsController < Devise::SessionsController
+    include Kaui::ExceptionHelper
+
     layout Kaui.config[:layout]
 
     skip_before_action :check_for_redirect_to_tenant_screen, raise: false
 
     # The sign-in flow eventually calls authenticate! from config/initializers/killbill_authenticatable.rb
 
+    rescue_from(StandardError) do |exception|
+      @error = standardize_exception(exception)
+      render 'kaui/errors/500', status: 500, layout: false
+    end
+
     protected
 
     # Override after_sign_in_path_for to not have to rely on the default 'root' config which we want to keep on home#index

diff --git a/app/helpers/kaui/exception_helper.rb b/app/helpers/kaui/exception_helper.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Kaui
+  module ExceptionHelper
+    def standardize_exception(exception)
+      case exception
+      when ActiveRecord::DatabaseConnectionError
+        "Unable to connect to the database."
+      when Errno::ECONNREFUSED
+        url = exception.message.match(/for "(.*)" port/)[1] rescue nil
+        (KillBillClient.url.include? url) ? "Unable to connect to the Kill Bill server." : nil
+      when -> (e) { e.class.name.start_with?('KillBillClient::API') }
+        "Error while communicating with the Kill Bill server."
+      else
+        nil
+      end
+    end
+  end
+end
diff --git a/app/views/kaui/errors/500.html.erb b/app/views/kaui/errors/500.html.erb
@@ -0,0 +1,29 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <title>We're sorry, but something went wrong (500)</title>
+    <style type="text/css">
+      body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+      div.dialog {
+        width: 35em; /* Increase the width of the dialog */
+        padding: 1em 6em; /* Increase the padding of the dialog */
+        margin: 4em auto 0 auto;
+        border: 1px solid #ccc;
+        border-right-color: #999;
+        border-bottom-color: #999;
+        font-size: 1.2em; /* Increase the font size in the dialog */
+      }
+      h1 { font-size: 100%; color: #f00; line-height: 1.0em; } /* Increase the font size of the title */
+    </style>
+  </head>
+
+  <body>
+    <!-- This file lives in public/500.html -->
+    <div class="dialog">
+      <h1>We're sorry, but something went wrong.</h1>
+      <% if @error.present? %>
+        <p><%= @error %></p>
+      <% end %>
+    </div>
+  </body>
+</html>
diff --git a/config/routes.rb b/config/routes.rb
@@ -22,6 +22,7 @@ def nested_param
              controllers: { sessions: 'kaui/sessions', registrations: 'kaui/registrations' }
 
   root to: 'home#index', as: 'kaui'
+  get '/500', to: 'errors#show', code: 500
 
   scope '/accounts' do
     match '/pagination' => 'accounts#pagination', :via => :get, :as => 'accounts_pagination'