refactor(test): Use valid test versions #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With killercup#480, we'll be parsing the `Cargo.toml`s which will fail with our test "versions". To make these still stand out, I used the metadata field and chose a ridiculously large version.
|
Nice! Glad to see this becoming more realistic :) Also, thank you so much for all your work on cargo-edit recently! I've taken this opportunity to add you as a collaborator with merge access. <3 |
|
Glad to see you are still around to a degree! Thanks for the merge-access; that'll hopefully speed some things up. |
|
Yeah, I'm in a very passive mode for this project right now. It does what I wanted and everything else is just sugar on top that some very capable people are doing :) Also cc @ordian -- thanks so much for keeping up the reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #480, we'll be parsing the
Cargo.tomls which will fail with ourtest "versions". To make these still stand out, I used the metadata field and
chose a ridiculously large version.