Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize doc index page slide show animation and refactor related React code #104

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

XDean
Copy link
Contributor

@XDean XDean commented Sep 30, 2021

Motivation

The origin slide animation is not fluent.
The previous image is disappeared but not fade out.

This PR is to optimize the animation effect and the out-of-date React code.

Changes

  • use React state instead of control DOM element
  • use transition instead of keyframe animation

Related

Origin slide

xplorer-slide-old

New slide

xplorer-slide-new

@vercel
Copy link

vercel bot commented Sep 30, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/7gfRGMybUgoXBerWqHYbcSAwj7zZ
✅ Preview: https://xplorer-git-fork-xdean-optimizedocindexslide-kimlimjustin.vercel.app

@XDean
Copy link
Contributor Author

XDean commented Sep 30, 2021

Wow @kimlimjustin. You approved so quickly!

@kimlimjustin
Copy link
Owner

kimlimjustin commented Sep 30, 2021

Wow @kimlimjustin. You approved so quickly!

Haha, Thanks tho! Eh, I just realized that you doubled the windows image, it's supposed to be macOS on the third slide, and also you forgot to edit the alt of the image. Could you please change it? Thanks

@XDean
Copy link
Contributor Author

XDean commented Sep 30, 2021

Sorry @kimlimjustin . I'm so careless. I will correct it.

@kimlimjustin
Copy link
Owner

Sorry @kimlimjustin . I'm so careless. I will correct it.

It's okay haha, I don't even realize it when reviewing your code until I see the preview website xd

@XDean
Copy link
Contributor Author

XDean commented Sep 30, 2021

Emm, it's weird. The screenshot gif is correct. Anyway, I have fixed it.

@kimlimjustin kimlimjustin merged commit 0643674 into kimlimjustin:master Sep 30, 2021
@kimlimjustin
Copy link
Owner

TYSM tho, anyways, any other PRs regarding the website will be appreciated, including translation (cuz I don't have time to edit the website since I got a lot of works with Xplorer itself).

@XDean XDean deleted the optimize_doc_index_slide branch September 30, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants