-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize doc index page slide show animation and refactor related React code #104
optimize doc index page slide show animation and refactor related React code #104
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel. @kimlimjustin first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/7gfRGMybUgoXBerWqHYbcSAwj7zZ |
Wow @kimlimjustin. You approved so quickly! |
Haha, Thanks tho! Eh, I just realized that you doubled the windows image, it's supposed to be macOS on the third slide, and also you forgot to edit the |
Sorry @kimlimjustin . I'm so careless. I will correct it. |
It's okay haha, I don't even realize it when reviewing your code until I see the preview website xd |
Emm, it's weird. The screenshot gif is correct. Anyway, I have fixed it. |
TYSM tho, anyways, any other PRs regarding the website will be appreciated, including translation (cuz I don't have time to edit the website since I got a lot of works with Xplorer itself). |
Motivation
The origin slide animation is not fluent.
The previous image is disappeared but not fade out.
This PR is to optimize the animation effect and the out-of-date React code.
Changes
Related
Origin slide
New slide