Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring select file operation #166

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Refactoring select file operation #166

merged 3 commits into from
Oct 25, 2021

Conversation

AlexHladin
Copy link
Contributor

Motivation

Source code in the selectShortcut function section could in the select.ts be refactored and split into a few small functions. The PR does this job.

Changes

  1. Refactored logic for arrow up, down, left, and right key to smaller function.
  2. Created elementClassNameContains function that incapsulates logic for searching file in the in the element's className list

@vercel
Copy link

vercel bot commented Oct 23, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

However, have you tried the changes locally? Something seems to be broken in my case

src/Components/Functions/elementClassNameContains.ts Outdated Show resolved Hide resolved
AlexHladin and others added 2 commits October 24, 2021 13:24
@AlexHladin
Copy link
Contributor Author

Thanks for your PR!

However, have you tried the changes locally? Something seems to be broken in my case

@kimlimjustin could you please try once again, I guess I fixed it

@vercel
Copy link

vercel bot commented Oct 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/8NUxqvTqKRmp1bT2fx46jWTm3KSa
✅ Preview: https://xplorer-git-fork-alexhladin-refactor-select-40376b-kimlimjustin.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants