Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README.md #206

Merged
merged 3 commits into from
Dec 31, 2021
Merged

Fix typo in README.md #206

merged 3 commits into from
Dec 31, 2021

Conversation

AlexHladin
Copy link
Contributor

@AlexHladin AlexHladin commented Dec 30, 2021

Motivation

Fix typo.

Changes

Fixed typo.

Related

(Optional, link(s) of related Issues or PR related to this PR, If this PR adds or changes functionality, please take some time to update the docs and link your PR here.)

Additional Comments

(Anything, optional)

@vercel
Copy link

vercel bot commented Dec 30, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

updater – ./api/updater

🔍 Inspect: https://vercel.com/kimlimjustin/updater/6vvgXjjGshBocZVpoWPza779T3DD
✅ Preview: https://updater-git-fork-alexhladin-patch-2-kimlimjustin.vercel.app

xplorer – ./docs

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/9bpSspfKNDEvBXZ3p9yBkE5U6zov
✅ Preview: https://xplorer-git-fork-alexhladin-patch-2-kimlimjustin.vercel.app

Copy link
Contributor

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you add a a between Recommend us and feature? Grammar error, it's best corrected here.

@AlexHladin
Copy link
Contributor Author

@im-coder-lg done.

@im-coder-lg
Copy link
Contributor

im-coder-lg commented Dec 30, 2021

Thanks! LGTM
Edit: am I supposed to use that?

Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, could you please edit the docs site page too together with this?

@im-coder-lg
Copy link
Contributor

Oh yeah, could you please edit the docs site page too together with this?

Who, me or @AlexHladin? Confused.

@kimlimjustin
Copy link
Owner

@AlexHladin ofc, he opened this PR haha, but if he doesn't respond in 48 hours, then please edit it @im-coder-lg .

@im-coder-lg
Copy link
Contributor

I know that @AlexHladin will, but I also need to check some things in the documentation. Will open a PR soon, maybe by the second week of January after finding the typos.

@AlexHladin
Copy link
Contributor Author

@AlexHladin ofc, he opened this PR haha, but if he doesn't respond in 48 hours, then please edit it @im-coder-lg .

@kimlimjustin sorry, not really understand what should I edit. Could you clarify it?
Btw, I just saw an issue in the Readme.md and I've decided to fix it immediately, not sure that this action requires something else.

@kimlimjustin
Copy link
Owner

Oh, this is the source to the site docs, could you please update that together with this PR? cuz there's the same typo there too (I copied it when writing it hehe), thanks a lot

@AlexHladin
Copy link
Contributor Author

Oh, this is the source to the site docs, could you please update that together with this PR? cuz there's the same typo there too (I copied it when writing it hehe), thanks a lot

@kimlimjustin ok, will do it

@AlexHladin
Copy link
Contributor Author

@kimlimjustin done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants