Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Enhancement #80

Merged
merged 2 commits into from
Sep 27, 2021
Merged

UI Enhancement #80

merged 2 commits into from
Sep 27, 2021

Conversation

dkhd
Copy link
Contributor

@dkhd dkhd commented Sep 27, 2021

Hi @kimlimjustin

Please take a look at this PR.

Motivation

After forking the repository, I spotted several parts that are related to UIs that can be improved like font size, padding, margin, etc, so I make the changes. This PR is purely for aesthetic purpose.

Changes

There are several changes I've made, and some of them are:

  • Reducing the font size
  • Increasing the padding & margin on the sidebar
  • Removing the border & background from Favorites & Drives at main panel (those were look like selected-state before the changes)
  • Increasing context menu padding
  • Adding context menu hover state
  • Moving the "Settings" text to left side, as well as the back button

Please take a look at these screenshots below (I'm using Elementary OS 6) to see the changes:

Home; dark

Context menu; dark

Home; light

Context menu; light

Related

None

Additional Comments

During the development, I found these two issues (UI-related issues). I will submit these to the issue tab later, but I will put them here first:

  • To make the selected-state active in the "Favorite" and "Drives" section in the main panel (not sidebar), it can only be clicked/activated from the edge of the border in hover state
  • Context menu is clipped if opened at the edge of the window

@vercel
Copy link

vercel bot commented Sep 27, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design looks good to me! TYSM!

@vercel
Copy link

vercel bot commented Sep 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/2SsMvZ77CQuRj6kEoTEQ4SzNLUG7
✅ Preview: https://xplorer-git-fork-dkhd-master-kimlimjustin.vercel.app

@kimlimjustin
Copy link
Owner

Oops, it seems like you edited the yarn.lock file and the workflow failed. I'll take a look into it.

@kimlimjustin kimlimjustin merged commit fafdefa into kimlimjustin:master Sep 27, 2021
@kimlimjustin
Copy link
Owner

I'm really sorry but the favorites section and the drives section layout are also being affected when changing Layout Mode, could you please deliver a fix for that @dkhd? It's okay if you're not available tho :)

Salam

@dkhd
Copy link
Contributor Author

dkhd commented Sep 27, 2021

Hi @kimlimjustin

Sure I'll check it. But maybe tomorrow? Currently I'm not available.

What do you think?

@kimlimjustin
Copy link
Owner

Hi @kimlimjustin

Sure I'll check it. But maybe tomorrow? Currently I'm not available.

What do you think?

It's okay (I need to do my homework too haha), thanks and sorry for disturbing you

@dkhd
Copy link
Contributor Author

dkhd commented Sep 27, 2021

Haha. No worries, young man..

You did a great job 👍

@dkhd
Copy link
Contributor Author

dkhd commented Sep 28, 2021

hi @kimlimjustin

Please kindly check your email :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants