Fixing a bug with removing scheduling conflicts.

The method was indiscriminately removing any temporal models that were scheduling after the start of the new one. Now the method actually checks if a scheduling conflict exists before removing on those entries.
kimmelsg · Jan 5, 2017 · 7e0c02a · 7e0c02a
1 parent 529c9b5
commit 7e0c02a
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/Temporal.php b/src/Temporal.php
@@ -99,7 +99,13 @@ protected function removeSchedulingConflicts()
             return $this->getQuery()->where('valid_start', '>', Carbon::now())->delete();
         }
 
-        $this->getQuery()->where('valid_start', '>', $this->valid_end)->delete();
+        $this->getQuery()
+            ->where('valid_start', '<', $this->valid_end)
+            ->where(function ($query) {
+                $query->whereNull('valid_end')
+                    ->orWhere('valid_end', '>', $this->valid_start);
+            })
+            ->delete();
     }
 
     /**
@@ -123,7 +129,9 @@ protected function endCurrent()
      */
     private function getQuery()
     {
-        $query = $this->where($this->temporalParentColumn, $this->{$this->temporalParentColumn});
+        $query = $this
+            ->where($this->primaryKey, '!=', $this->{$this->primaryKey})
+            ->where($this->temporalParentColumn, $this->{$this->temporalParentColumn});
 
         if ($this->temporalPolymorphicTypeColumn) {
             $query->where($this->temporalPolymorphicTypeColumn, $this->{$this->temporalPolymorphicTypeColumn});

diff --git a/tests/TemporalTest.php b/tests/TemporalTest.php
@@ -164,6 +164,27 @@ public function testItRemovesAScheduledCommissionWhenANewOneIsCreated()
         $this->assertNull($scheduledCommission->fresh());
     }
 
+    /**
+     * Tests...
+     */
+    public function testItOnlyRemovesAScheduledCommissionWhenThereIsAConflict()
+    {
+        $scheduledCommission = TemporalTestCommission::create([
+            'id' => 2,
+            'agent_id' => 1,
+            'valid_start' => Carbon::now()->addDays(20),
+            'valid_end' => null
+        ]);
+        TemporalTestCommission::create([
+            'id' => 3,
+            'agent_id' => 1,
+            'valid_start' => Carbon::now(),
+            'valid_end' => Carbon::now()->addDays(19)
+        ]);
+
+        $this->assertNotNull($scheduledCommission->fresh());
+    }
+
     /**
      * Tests...
      */