-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access route properties using getters #2
Conversation
The upgrade to ember 1.10.0-beta broke accessing `this.title` directly. It does mean that if you have a computed property, you can't pass the token list.
Thanks a bunch for doing this! Just one thing: this is an addon where the consumer don't necessarily have prototype extension turned on, so we should use the alternative form for Not like this: var myThing = this.get('theThing'); Like this: // declare this at the top
var get = Ember.get;
var myThing = get(this, 'theThing'); Thanks again! |
Sure thing, just updated it to use Ember.get instead. |
Awesome! I will have to test this a little bit, but it seems good :) |
any updates on this? |
Yeah - I really wanted to set aside some time to add tests before merging and releasing this, but I never got around to it. I have tested manually, and will merge and release a new version right now. Really sorry about the wait. |
Access route properties using getters
Published as v0.0.2 |
…and now there are tests. Thanks for poking me :) |
👍 Awesome! |
The upgrade to ember 1.10.0-beta broke accessing
this.title
directly.It does mean that if you have a computed property, you can't pass the token list.