Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access route properties using getters #2

Merged
merged 3 commits into from
Feb 20, 2015

Conversation

mnutt
Copy link
Contributor

@mnutt mnutt commented Feb 2, 2015

The upgrade to ember 1.10.0-beta broke accessing this.title directly.

It does mean that if you have a computed property, you can't pass the token list.

The upgrade to ember 1.10.0-beta broke accessing `this.title` directly.

It does mean that if you have a computed property, you can't pass the token list.
@kimroen
Copy link
Owner

kimroen commented Feb 3, 2015

Thanks a bunch for doing this!

Just one thing: this is an addon where the consumer don't necessarily have prototype extension turned on, so we should use the alternative form for Ember.get. Would you mind amending your commit to doing it this way?

Not like this:

var myThing = this.get('theThing');

Like this:

// declare this at the top
var get = Ember.get;

var myThing = get(this, 'theThing');

Thanks again!

@mnutt
Copy link
Contributor Author

mnutt commented Feb 3, 2015

Sure thing, just updated it to use Ember.get instead.

@kimroen
Copy link
Owner

kimroen commented Feb 3, 2015

Awesome! I will have to test this a little bit, but it seems good :)

@ahmed1490
Copy link

any updates on this?

@kimroen
Copy link
Owner

kimroen commented Feb 20, 2015

Yeah - I really wanted to set aside some time to add tests before merging and releasing this, but I never got around to it.

I have tested manually, and will merge and release a new version right now. Really sorry about the wait.

kimroen added a commit that referenced this pull request Feb 20, 2015
Access route properties using getters
@kimroen kimroen merged commit 03aa8ec into kimroen:master Feb 20, 2015
@kimroen
Copy link
Owner

kimroen commented Feb 20, 2015

Published as v0.0.2

@kimroen
Copy link
Owner

kimroen commented Feb 20, 2015

…and now there are tests. Thanks for poking me :)

@ahmed1490
Copy link

👍 Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants