-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Glimmer 2. Fixes #46. #49
Conversation
@kimroen any reason not to merge this? |
Works for me on ember v2.9.0-beta.1. |
@kimroen Any chance of merging this fix and doing a new release? |
PSA: I'm sure this is common knowledge, but you can easily point your
But certainly I'm 👍 merging and getting a new release out. |
@workmanw Thanks, I didn't know about the short syntax, I'm currently referencing the source branch:
|
I encountered this problem as well and this PR fixes it. Will this be landing soon? |
Thanks @workmanw |
any reason not to accept this PR? |
Ping: @kimroen. Shameless bump. Ember v2.9.0-beta.4 was just cut today. Any chance this PR can be merged and a new release can be cut before 2.9 ships? |
@workmanw Thanks for checking in. I'll absolutely do so. I've been away for a bit, but I'm back and will get to it: https://twitter.com/kimroen/status/783060891944230912 Thanks for helping eachother out ❤️ |
@kimroen Hehe, I definitely know how that goes. Thanks! |
Travis is acting up, but I pulled down and ran everything locally to make sure. All good. I'll take a look at the Fastboot-related PRs and see if it makes sense to add those or release this separately. |
Released in |
This also improves the logic for the
document.title = title
fallback.Fixes #46