Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Glimmer 2. Fixes #46. #49

Merged
merged 1 commit into from
Oct 9, 2016

Conversation

workmanw
Copy link
Contributor

@workmanw workmanw commented Aug 22, 2016

This also improves the logic for the document.title = title fallback.

Fixes #46

@asakusuma
Copy link

@kimroen any reason not to merge this?

@felixbuenemann
Copy link

Works for me on ember v2.9.0-beta.1.

@felixbuenemann
Copy link

@kimroen Any chance of merging this fix and doing a new release?

@workmanw
Copy link
Contributor Author

PSA: I'm sure this is common knowledge, but you can easily point your package.json to use this PR. This is what I've done in the interim until a new release is cut.

--  "ember-cli-document-title": "0.3.1",
++  "ember-cli-document-title": "kimroen/ember-cli-document-title#pull/49/head",

But certainly I'm 👍 merging and getting a new release out.

@felixbuenemann
Copy link

@workmanw Thanks, I didn't know about the short syntax, I'm currently referencing the source branch:

"ember-cli-document-title": "git+https://github.com/kategengler/ember-cli-document-title.git#glimmer2-support"

@josemarluedke
Copy link

josemarluedke commented Sep 13, 2016

I encountered this problem as well and this PR fixes it. Will this be landing soon?

@bradleypriest
Copy link

Thanks @workmanw

@yankeeinlondon
Copy link

any reason not to accept this PR?

@workmanw
Copy link
Contributor Author

workmanw commented Oct 3, 2016

Ping: @kimroen. Shameless bump. Ember v2.9.0-beta.4 was just cut today. Any chance this PR can be merged and a new release can be cut before 2.9 ships?

@kimroen
Copy link
Owner

kimroen commented Oct 4, 2016

@workmanw Thanks for checking in. I'll absolutely do so.

I've been away for a bit, but I'm back and will get to it: https://twitter.com/kimroen/status/783060891944230912

Thanks for helping eachother out ❤️

@workmanw
Copy link
Contributor Author

workmanw commented Oct 4, 2016

I've been away for a bit, but I'm back and will get to it.

@kimroen Hehe, I definitely know how that goes. Thanks!

@kimroen
Copy link
Owner

kimroen commented Oct 9, 2016

Travis is acting up, but I pulled down and ran everything locally to make sure. All good.

I'll take a look at the Fastboot-related PRs and see if it makes sense to add those or release this separately.

@kimroen kimroen merged commit c1dc661 into kimroen:master Oct 9, 2016
kimroen added a commit that referenced this pull request Oct 9, 2016
@kimroen
Copy link
Owner

kimroen commented Oct 9, 2016

Released in ember-cli-document-title@0.3.2 - thanks again 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants