Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rework]: Bring in fork changes #92

Merged
merged 8 commits into from
Jan 9, 2021
Merged

[Rework]: Bring in fork changes #92

merged 8 commits into from
Jan 9, 2021

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Feb 16, 2020

@snewcomer snewcomer self-assigned this Feb 16, 2020
package.json Outdated
@@ -25,7 +25,7 @@
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint .",
"start": "ember serve",
"test": "ember test && ember fastboot:test",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the fork this was removed as well. Not sure of the context but I'm having trouble getting the tests to pass/even run with the addon fastboot tests locally and CI.

Copy link
Collaborator Author

@snewcomer snewcomer Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scratch that. It works locally (after some time). Just not in CI

@snewcomer snewcomer merged commit 043a886 into master Jan 9, 2021
@snewcomer snewcomer deleted the sn/forked-changes branch January 9, 2021 18:30
@snewcomer snewcomer changed the title Bring in fork changes [Rework]: Bring in fork changes Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant