-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rework]: Bring in fork changes #92
Conversation
package.json
Outdated
@@ -25,7 +25,7 @@ | |||
"lint:hbs": "ember-template-lint .", | |||
"lint:js": "eslint .", | |||
"start": "ember serve", | |||
"test": "ember test && ember fastboot:test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see in the fork this was removed as well. Not sure of the context but I'm having trouble getting the tests to pass/even run with the addon fastboot tests locally and CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scratch that. It works locally (after some time). Just not in CI
Thanks to those who contributed to this!
ref - mike-north/ember-cli-document-title-northm@6d330c0
mike-north/ember-cli-document-title-northm#64
mike-north/ember-cli-document-title-northm@70196a6#diff-e5e9bb873d4752465a401c95cc77154e