-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: KINDE_SCOPE + getUser upgrades #186
Conversation
WalkthroughThe recent changes enhance the configuration and user data retrieval capabilities of the project. A new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- src/config/index.js (3 hunks)
- src/routerClients/AppRouterClient.js (2 hunks)
- src/routerClients/PagesRouterClient.js (1 hunks)
- src/session/getUser.js (1 hunks)
- types.d.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- types.d.ts
Additional comments not posted (7)
src/session/getUser.js (3)
23-27
: Ensure correct token type forphone_number
claim.The
phone_number
claim is fetched using theid_token
. Verify if this is the correct token type.
28-32
: Ensure correct token type forusername
claim.The
username
claim is fetched using theid_token
. Verify if this is the correct token type.
35-36
: LGTM!The changes to include
phone_number
andusername
in the user object look good.src/routerClients/PagesRouterClient.js (1)
12-12
: LGTM!The addition of the
scope
property to theclientConfig
looks good.src/routerClients/AppRouterClient.js (1)
14-14
: LGTM!The addition of the
scope
property to theclientConfig
looks good.src/config/index.js (2)
57-57
: LGTM!The addition of the
scope
property with a default value looks good.
94-95
: LGTM!The addition of the
framework
property looks good.
feat: KINDE_SCOPE + getUser upgrades
Explain your changes
KINDE_SCOPE
in.env
getUser
now returns phone and usernameSuppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.