Peter/v2 hot fixes #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveOrDead
requested changes
Nov 6, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@kinde-oss/kinde-auth-nextjs", | |||
| "version": "2.0.0-alpha.2", | |||
| "version": "2.0.0", | |||
| @@ -10,11 +9,10 @@ export function authMiddleware(request) { | |||
| let isAuthenticated = false; | |||
| const nextUrl = trimTrailingSlash(request.nextUrl.href); | |||
| const logoutUrl = trimTrailingSlash(config.postLogoutRedirectURL); | |||
| const kinde_token = request.cookies.get('kinde_token'); | |||
| const kinde_token = request.cookies.get('access_token'); | |||
There was a problem hiding this comment.
@peterphanouvong is this right?
There was a problem hiding this comment.
@DaveOrDead yea, using TS SDK sets access_token in cookies instead of kinde_token
There was a problem hiding this comment.
Hmm I see. Seems this would create breaking changes for anyone accessing the cookie directly.
Could we instead update the TS SDK to allow a cookie name to be passed? That way we can pass kinde_token from the NextJS SDK which keeps it working as it was for existing users?
tsconfig.json
Outdated
| @@ -18,5 +18,8 @@ | |||
| // "Go to Definition" in VSCode | |||
| "declarationMap": true, | |||
| "esModuleInterop": true | |||
| // "checkJs": true, | |||
| // "strict": true, | |||
| // "jsx": "react" | |||
There was a problem hiding this comment.
@peterphanouvong lets remove commented code
There was a problem hiding this comment.
@DaveOrDead done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
Suppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.