Testing link-checker-gpt 0.1.0-beta #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
force-pushed
the
test-prerelease
branch
from
3b40e14
to
2a43434
Compare
added 3 commits
August 17, 2023 10:02
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Closed
added 12 commits
August 17, 2023 17:54
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Dockerize
|
Let's give it a configurable URL, configure it to check for a healthy sitemap and configurable timeout We can clarify in the README how to adopt it in your repo, what options it has, and test it in a repository for some other domain. Those things shouldn't be very difficult to add. https://developer.fermyon.com/bartholomew/seo#generating-a-sitemap (We have one of these blogs and we can add a sitemap to it to make it work with this, it's recommended anyway and I haven't done it yet...) |
added 11 commits
August 18, 2023 08:49
Move the workflow to root directory, following: https://docs.github.com/en/actions/creating-actions/about-custom-actions#good-practices-for-release-management Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
preserve it for posterity in a separate .yml Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
but we can tell it to try again and keep polling until timeout or the PREVIEW_URL site becomes ready. Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
added 9 commits
August 21, 2023 12:47
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
the advice to use env is for scripts that users embed in their own repos https://docs.github.com/en/actions/using-workflows/using-github-cli-in-workflows we need to take githubToken as an input, evidently Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
not sure which of these or if both are effective, but let's see if this breaks anything (it ought not!) Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kingdonb
changed the title
|
The |
|
I will close |
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15
Unsure if we can use v0 prerelease versioning for a GitHub action.
May just promote v1 if everything seems to be working. Still need to finish testing:
There needs to be a PR so we can see the test workflow executing.
It will still fail, because we are waiting for this one and its friends to merge: