chore: plugin pack command for 2 #916

tasshi-me · 2024-10-24T20:20:35Z

Why

Support plugin manifest v2.

What

refactor plugin module
support manifest v2
add plugin info command

How to test

Manual test example:

## Prepare plugin project to /tmp/hello-kintone

## Build cli-kintone
pnpm install
pnpm build

## Show pack --help
node cli.js plugin pack --help

## Run pack command
node cli.js plugin pack --input /tmp/hello-kintone/src/ --output /tmp/dist/plugin.zip

ls /tmp/dist # => plugin.zip and .ppk exist

## Run pack command with ppk file
node cli.js plugin pack --input /tmp/hello-kintone/src/ --output /tmp/dist/plugin-2.zip --private-key /tmp/dist/*.ppk

ls /tmp/dist # => plugin.zip, plugin-2.zip, and .ppk exist

## Run info command
node cli.js plugin info --input /tmp/dist/plugin.zip # => printing plugin id, name, etc.

Checklist

Read CONTRIBUTING.md
Updated documentation if it is required.
Added/updated tests if it is required. (or tested manually)
Passed pnpm lint and pnpm test on the root directory.

tasshi-me · 2024-10-25T05:28:53Z

前のPRでレビューあったところ

tasshi-me

補足コメント書きました。
かなり大胆にリファクタしたので、↓の概念図も参考にしてください！ 🙏

tasshi-me · 2024-10-28T10:01:00Z

package.json

    "node-rsa": "^1.1.1",
-    "stream-buffers": "^3.0.3",


stream-buffersは Node.js 標準の Utility Consumers に置き換えが案内されていたので置き換えた。
https://www.npmjs.com/package/stream-buffers

tasshi-me · 2024-10-28T10:01:30Z

package.json

@@ -112,13 +110,9 @@
    "chokidar": "^4.0.1",
    "csv-parse": "^4.16.3",
    "csv-stringify": "5.6.5",
-    "debug": "^4.3.7",


debug はcli-kintoneのlogger.debug|traceに置き換えた。

tasshi-me · 2024-10-28T10:03:50Z

package.json

    "https-proxy-agent": "^7.0.5",
    "iconv-lite": "^0.6.3",
-    "mkdirp": "^3.0.1",


fs.promises.mkdir(data, {recursive: true}) に置き換え

tasshi-me · 2024-10-28T10:04:08Z

package.json

@@ -112,13 +110,9 @@
    "chokidar": "^4.0.1",
    "csv-parse": "^4.16.3",
    "csv-stringify": "5.6.5",
-    "debug": "^4.3.7",
-    "execa": "^9.4.1",


使用していたテストを消した。

tasshi-me · 2024-10-28T10:26:07Z

src/plugin/core/crypto/index.ts

+export { PublicKey } from "./public-key";
+export type { PublicKeyInterface } from "./public-key";
+export { PrivateKey } from "./private-key";
+export type { PrivateKeyInterface } from "./private-key";


PublicKey と PrivateKey は変わることは当面なさそうだしInterfaceを切らなくても良さそう。
（アルゴリズムなどが変わるタイミングでIFを切れば良さそう）

tasshi-me · 2024-10-28T12:25:55Z

src/plugin/packer/index.ts

-
-const debug = _debug("packer");
-
-const packer = (


packerの処理はPluginZip.build()に移動した。

tasshi-me · 2024-10-28T12:27:01Z

src/plugin/packer/pack-plugin-from-manifest.ts

-import packer from "./index";
-import { createContentsZip } from "./create-contents-zip";
-
-export const packPluginFromManifest = (


こちらもPluginZip.build()に集約

tasshi-me · 2024-10-28T12:27:38Z

website/docs/guide/commands/plugin-info.md

@@ -0,0 +1,29 @@
+---
+sidebar_position: 1400
+draft: true


draft: trueなのでローカルビルドでした表示されない

tasshi-me · 2024-10-28T16:40:43Z

src/cli/stability.ts

+ * @param stability "experimental" or "deprecated"
+ * @param message additional information
+ */
+export const setStability = <T = {}, U = {}>(


https://github.com/kintone/cli-kintone/pull/915/files#r1815855917 の対応

setStability(cmd, stability, msg) 関数を追加した。
ヘルプメッセージにStabilityが表示され、実行時に警告が出るようになる。

どこかのflagsにstabilityの情報を集約して、それに連動して表示が変わるようにしたかったが、yargsの仕組み上難しそうだった。

コマンドの生成を全てラップするヘルパー関数を置けば実現できるが、既存のレコード系のコマンドにも影響が出るので今回は個別のコマンドをラップする方式にした。

src/plugin/packer/cli.ts

shabaraba

@tasshi-me
いくつかコメントしました！
定義がわかりやすくて処理が追いやすかったです！

src/plugin/core/manifest/interface.ts

src/plugin/core/contents/zip.ts

src/plugin/core/plugin/index.ts

src/plugin/packer/cli.ts

tasshi-me

レビュー対応

shabaraba

ご対応ありがとうございました！良さそうです！

tasshi-me self-assigned this Oct 24, 2024

tasshi-me force-pushed the feat/plugin-packer branch from 9c9a9f2 to a8e6a7d Compare October 24, 2024 20:29

tasshi-me force-pushed the feat/plugin-packer-2 branch from 0882ade to d56df1f Compare October 24, 2024 21:25

tasshi-me mentioned this pull request Oct 25, 2024

chore: add plugin pack command (Experimental) #915

Merged

4 tasks

Base automatically changed from feat/plugin-packer to main October 25, 2024 08:15

tasshi-me added 6 commits October 25, 2024 17:26

refactor crypto module

50cc317

add command guide in docs

6fdc82e

use cli-kintone logger instead of console

51c43fb

refactor manifest module

ae959ae

replace callbacks with async await

50eccd2

add description for watch option

5ec52a6

tasshi-me force-pushed the feat/plugin-packer-2 branch from 41f2bc3 to 5ec52a6 Compare October 25, 2024 08:27

tasshi-me added 9 commits October 25, 2024 23:31

extract pluginZip, contentsZip, and manifest modules

78569d4

use ContentsZip class

20c9f66

refactor plugin-zip

e12c6c4

wip

7ee49ad

wip

349c9ac

add trailing line break to ppk file

802d3a9

replace callback with async await

f00fe1d

refactor contents-zip

97837a8

add ManifestStaticInterface

32cafad

tasshi-me force-pushed the feat/plugin-packer-2 branch from c2d994a to 32cafad Compare October 25, 2024 19:26

tasshi-me added 7 commits October 26, 2024 04:33

refactor manifest module

a5de6fb

support manifest v2

c8147c9

rename cli() to run()

ade24d1

fix manifest parsing process

5b5345e

add tests for manifest v2

72e56b2

deprecate packPluginFromManifest

b9a1a4e

fix cli entrypoint

e0506b5

tasshi-me added 4 commits October 28, 2024 18:49

Merge remote-tracking branch 'origin/main' into feat/plugin-packer-2

8080a6b

delete files generated by tests

50a3e72

add JSDoc

96c0995

add setStability() helper function

3312a0f

tasshi-me force-pushed the feat/plugin-packer-2 branch from 62f1587 to 3312a0f Compare October 28, 2024 16:38

tasshi-me commented Oct 28, 2024

View reviewed changes

tasshi-me marked this pull request as ready for review October 28, 2024 16:54

tasshi-me requested a review from a team as a code owner October 28, 2024 16:54

tasshi-me requested review from chihiro-adachi and shabaraba and removed request for a team October 28, 2024 16:54

shabaraba requested changes Oct 30, 2024

View reviewed changes

tasshi-me added 4 commits November 1, 2024 18:36

reorder run process

99a80b7

fix typo in a comment

68254c1

rename cli to pack

67bffa2

rename create methods to generate or build

95110a4

tasshi-me force-pushed the feat/plugin-packer-2 branch from 39db43e to 95110a4 Compare November 2, 2024 08:33

tasshi-me added 3 commits November 2, 2024 17:41

stop exporting experimental function

aff6ce3

refactor plugin module

1b18965

add comment to private constructors

aacf5bf

tasshi-me commented Nov 2, 2024

View reviewed changes

tasshi-me added 3 commits November 2, 2024 19:10

Merge remote-tracking branch 'origin/main' into feat/plugin-packer-2

36b94a4

add TODO comments for future refactoring

b17869d

Merge remote-tracking branch 'origin/main' into feat/plugin-packer-2

e2078e1

shabaraba approved these changes Nov 6, 2024

View reviewed changes

tasshi-me merged commit 268817c into main Nov 6, 2024
32 checks passed

tasshi-me deleted the feat/plugin-packer-2 branch November 6, 2024 01:18

This was referenced Nov 6, 2024

chore: release 1.12.2 from main #913

Merged

chore: release 1.12.3 from main #931

Merged

trigger-github-actions-release bot mentioned this pull request Dec 5, 2024

chore: release 1.12.4 from main #950

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: plugin pack command for 2 #916

chore: plugin pack command for 2 #916

tasshi-me commented Oct 24, 2024 •

edited

Loading

tasshi-me commented Oct 25, 2024 •

edited

Loading

tasshi-me left a comment

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

tasshi-me Oct 28, 2024

shabaraba left a comment

tasshi-me left a comment

shabaraba left a comment

chore: plugin pack command for 2 #916

chore: plugin pack command for 2 #916

Conversation

tasshi-me commented Oct 24, 2024 • edited Loading

Why

What

How to test

Checklist

tasshi-me commented Oct 25, 2024 • edited Loading

tasshi-me left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shabaraba left a comment

Choose a reason for hiding this comment

tasshi-me left a comment

Choose a reason for hiding this comment

shabaraba left a comment

Choose a reason for hiding this comment

tasshi-me commented Oct 24, 2024 •

edited

Loading

tasshi-me commented Oct 25, 2024 •

edited

Loading