fix: Fixed so that empty strings are not quoted. #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
requested review from
tasshi-me and
shabaraba
and removed request for
a team
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The behavior of empty cells has changed due to an update to csv-stringify.
Double quotes are now given to empty cells.
https://github.com/kintone/cli-kintone/actions/runs/12022648673/job/33517941330
Pull Request for the cause
adaltas/node-csv#344
What
Change the quoted_match option so that it does not match an empty string.
How to test
Confirmed that the E2E test passes.
https://github.com/kintone/cli-kintone/actions/runs/12173755388/job/33954636716
Checklist
pnpm lintandpnpm teston the root directory.